-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][joint matrix] add missing licence to test and add combination-based query #12489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, update also sycl/sycl/test-e2e/Matrix/XMX8/element_wise_all_ops.cpp
, as after switching to common.hpp for other .cpp files and corresponding .hpp file, test in XMX8 folder will stop compiling.
Also despite it is temporary disabled, it passes for me locally, so it can be verified anyway that your changes are correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…t to add other types
Test requires further changes after discussion with author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one nit comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@intel/llvm-gatekeepers, all green, please help merge |
@dkhaldi there is a post-commit failure. There are two errors:
|
@martygrant, should I address the errors in this PR or open a new one? |
@dkhaldi apologies I should have detailed that. Yes please create a new PR for the fix, and leave a comment here to the new PR, thank you! |
Sounds good, thanks! |
Also, these errors should not be caused by my PR as I don't touch this file. |
@dkhaldi apologies you are correct. These fails are coming from the last PR to be merged - #11758 the same errors are in its post-commit run - https://github.com/intel/llvm/actions/runs/7697466128. I will comment on that PR to notify the author. |
No description provided.