Skip to content

[SYCL] Add support for ext_intel_matrix aspect #12512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 30, 2024

Conversation

lbushi25
Copy link
Contributor

@lbushi25 lbushi25 commented Jan 26, 2024

This PR adds the aspect for the sycl_ext_intel_matrix extension and allows code to verify whether the device supports the advanced matrix API. The aspect has been added to the aspect definition file and the corresponding macro has been added to the feature test file set to 1 meaning supported.

Copy link
Contributor

github-actions bot commented Jan 26, 2024

✅ With the latest revision this PR passed the C/C++ code formatter.

@lbushi25 lbushi25 changed the title Add support for sycl_ext_intel_matrix extension aspect [SYCL] Add support for sycl_ext_intel_matrix extension aspect Jan 27, 2024
@lbushi25 lbushi25 marked this pull request as ready for review January 27, 2024 15:55
@lbushi25 lbushi25 requested review from a team as code owners January 27, 2024 15:55
@lbushi25 lbushi25 requested a review from againull January 27, 2024 15:55
Copy link
Contributor

@maksimsab maksimsab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tools part LGTM.

nit: I would suggest ext_intel_matrix name of the aspect in the PR title instead of sycl_ext_intel_matrix.

@lbushi25 lbushi25 changed the title [SYCL] Add support for sycl_ext_intel_matrix extension aspect [SYCL] Add support for ext_intel_matrix aspect Jan 29, 2024
@lbushi25
Copy link
Contributor Author

@intel/llvm-reviewers-runtime friendly ping

Copy link
Contributor

@againull againull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test.

try {
return std::any_of(
supported_archs.begin(), supported_archs.end(), [=](const arch a) {
return const_cast<device_impl *>(this)->extOneapiArchitectureIs(a);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please make extOneapiArchitectureIs const method and remove const_cast from here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@lbushi25 lbushi25 requested a review from againull January 29, 2024 20:32
@lbushi25
Copy link
Contributor Author

@intel/llvm-gatekeepers This is good to go for merging!

@martygrant martygrant merged commit 9b33a43 into intel:sycl Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants