-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL] Add support for ext_intel_matrix aspect #12512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ With the latest revision this PR passed the C/C++ code formatter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tools part LGTM.
nit: I would suggest ext_intel_matrix
name of the aspect in the PR title instead of sycl_ext_intel_matrix
.
@intel/llvm-reviewers-runtime friendly ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test.
sycl/source/detail/device_impl.cpp
Outdated
try { | ||
return std::any_of( | ||
supported_archs.begin(), supported_archs.end(), [=](const arch a) { | ||
return const_cast<device_impl *>(this)->extOneapiArchitectureIs(a); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please make extOneapiArchitectureIs const method and remove const_cast
from here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
@intel/llvm-gatekeepers This is good to go for merging! |
This PR adds the aspect for the sycl_ext_intel_matrix extension and allows code to verify whether the device supports the advanced matrix API. The aspect has been added to the aspect definition file and the corresponding macro has been added to the feature test file set to 1 meaning supported.