[SYCL] Fix unused variable warnings #12523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
sergey-semenov
commented
Jan 29, 2024
| @@ -72,35 +72,30 @@ TEST_F(SchedulerTest, InOrderQueueSyncCheck) { | |||
| { | |||
| LimitedHandlerSimulation MockCGH; | |||
| EXPECT_CALL(MockCGH, depends_on).Times(0); | |||
| Queue->finalizeHandler<LimitedHandlerSimulation>( | |||
| MockCGH, detail::CG::CGTYPE::CodeplayHostTask, Event); | |||
| Queue->finalizeHandler<LimitedHandlerSimulation>(MockCGH, Event); | |||
There was a problem hiding this comment.
Actually, most of these checks are identical now, so the test needs to be trimmed down. I'd rather do so in a follow up PR though to fix post-commit ASAP.
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-reviewers-runtime Could you please have a quick look? |
aelovikov-intel
approved these changes
Jan 29, 2024
cperkinsintel
approved these changes
Jan 29, 2024
KseniyaTikhomirova
added a commit
to KseniyaTikhomirova/llvm
that referenced
this pull request
Mar 18, 2024
This reverts commit 2f56926.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes warnings introduced in #11758