[NFC][SYCL] Use get_elem_type_t instead of TryToGetElementType<T>::type #12738
Conversation
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| public: | ||
| using type = decltype(check(T())); | ||
| static constexpr bool value = !std::is_same_v<T, type>; | ||
| }; |
There was a problem hiding this comment.
Why do we keep TryToGetElementType?
There was a problem hiding this comment.
It has a single remaining use just below at line 650. Note that it's ::value, not ::type so I can't do the same replacement as in other places of this PR. I think it's possible to replace that as well somehow, but I've decided to wait until we can drop legacy builtins implementation and remove it after that.
There was a problem hiding this comment.
I see. I personally think value in this is unintuitive, so I would prefer we replace it, if nothing else then by just replacing the use with !std::is_same_v<T, get_elem_type_t<T>>.
There was a problem hiding this comment.
It's not immediately obvious if that would be an NFC or not, so I won't be doing it here.
| public: | ||
| using type = decltype(check(T())); | ||
| static constexpr bool value = !std::is_same_v<T, type>; | ||
| }; |
There was a problem hiding this comment.
I see. I personally think value in this is unintuitive, so I would prefer we replace it, if nothing else then by just replacing the use with !std::is_same_v<T, get_elem_type_t<T>>.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
No description provided.