[SYCL][E2E] Add gpu-intel-pvc-vg LIT param #12981
Conversation
Signed-off-by: Sarnie, Nick <[email protected]>
sycl/test-e2e/lit.cfg.py
Outdated
| if lit_config.params.get("gpu-intel-pvc", False): | ||
| config.available_features.add("gpu-intel-pvc") | ||
| else: | ||
| config.available_features.add("gpu-intel-pvc-vg") |
There was a problem hiding this comment.
Most of E2E tests using 'gpu-intel-pvc' now, need to use 'gpu-intel-pvc || gpu-intel-pvc-vg' to start on pvc-vg, right?
There was a problem hiding this comment.
If we want them to run on both PVC and PVC-VG, yes. I don't think there's any getting around that, right now as far as I see we only ever have one gpu-intel* true for a given device, having both gpu-intel-pvc and gpu-intel-pvc-vg be true would be a first and might cause problems.
|
@aelovikov-intel or @intel/llvm-reviewers-runtime Ping on this one, thanks! |
sycl/test-e2e/lit.cfg.py
Outdated
| if lit_config.params.get("gpu-intel-pvc", False) or \ | ||
| lit_config.params.get("gpu-intel-pvc-vg", False) : |
There was a problem hiding this comment.
Why do we "merge" the handling here? I'd prefer each to be processed on its own.
nit: I think...
| if lit_config.params.get("gpu-intel-pvc", False) or \ | |
| lit_config.params.get("gpu-intel-pvc-vg", False) : | |
| if (lit_config.params.get("gpu-intel-pvc", False) or | |
| lit_config.params.get("gpu-intel-pvc-vg", False)): |
is a more idiomatic formatting, but I'm no expert in snakes...
There was a problem hiding this comment.
i thought it would make it cleaner but yeah probably it did not, fixed in latest commit i think
i removed the multiline if so the second comment should be indirectly addressed
thx!
Signed-off-by: Sarnie, Nick <[email protected]>
I chose
gpu-intel-pvc-vginstead ofgpu-intel-pvcvgto match the device_arch here.