-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][PI] Add PI_ERROR_UNSUPPORTED_FEATURE error code #13036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][PI] Add PI_ERROR_UNSUPPORTED_FEATURE error code #13036
Conversation
This commit adds a new error code to PI as a mapping from UR_RESULT_ERROR_FEATURE_UNSUPPORTED. This relates to oneapi-src/unified-runtime#1448. Signed-off-by: Larsen, Steffen <[email protected]>
Thanks Steffen! Just thought if we can make this error more clearer. |
I agree that they could be replaced with the new error code, but I intentionally left them untouched as they are using deprecated exceptions and should be changed to using |
@intel/dpcpp-nativecpu-pi-reviewers - Friendly ping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Native CPU lgtm, thank you
This commit adds a new error code to PI as a mapping from UR_RESULT_ERROR_FEATURE_UNSUPPORTED. This relates to oneapi-src/unified-runtime#1448. Signed-off-by: Larsen, Steffen <[email protected]>
This commit adds a new error code to PI as a mapping from UR_RESULT_ERROR_FEATURE_UNSUPPORTED.
This relates to oneapi-src/unified-runtime#1448.