[SYCL][SCLA] Check allocated types are trivial #13105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Replace check for cv-unqualified object types with a check for cv-unqualified trivial type to be in line with the extension specification: > `ElementType` must be a cv-unqualified trivial type Signed-off-by: Victor Perez <[email protected]>
victor-eds
force-pushed
the
alloca-trivial
branch
from
6f87e34 to
091f432
Compare
victor-eds
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
victor-eds
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
@intel/dpcpp-cfe-reviewers can I get a review for this? Test failures unrelated to this change. |
smanna12
approved these changes
Mar 28, 2024
|
CI failures unrelated to these changes. |
|
@intel/llvm-gatekeepers can we get this merged? |
"Specialization Constant-Length Alloca" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace check for cv-unqualified object types with a check for cv-unqualified trivial types to be in line with the
sycl_ext_oneapi_private_allocaextension specification: