[SYCL][E2E] Switch Reduction/* tests to use <sycl/detail/core.hpp> #13126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| device d(default_selector_v); | ||
| context ctx{d}; | ||
| queue q{ctx, d}; | ||
| queue q; |
There was a problem hiding this comment.
has this been tested? I've seen this device..context..queue pattern before and it is used because on PVC with the new FLAT mode, the default selector will select all the L0 GPUs on the platform, which is two. So the queue gets created with a context that has two devices. Then, this sometimes leads to problems. The code you are replacing guarantees a context of one device.
I believe some of those problems have since been addressed, but not all. So we need to make sure this test change works on PVC.
There was a problem hiding this comment.
Yes, I've been developing the patch on PVC. Also, whenever this craziness is done on purpose, it better be properly commented.
cperkinsintel
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.