-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][E2E] Switch KernelFusion/* tests to use <sycl/detail/core.hpp> #13129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this changed needed? Can we provide an explanation in the PR description?
That is described in details in llvm/sycl/include/sycl/detail/core.hpp Lines 11 to 19 in e720b3a
and Lines 286 to 297 in e720b3a
|
Sounds like a good addition! Can you please add links to |
I think that would be too much overhead to keep adding them to all the PRs... Do you really need it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM.
Minor nit: There's a few files with an extra blank line after #include <sycl/detail/core.hpp>
, but could probably go in as-is.
Some of them were on purpose - to prevent |
Use
core.hpp
instead ofsycl.hpp
to improve CI compile times, as described here: https://github.com/intel/llvm/tree/sycl/sycl/test-e2e#sycldetailcorehpp