Skip to content

[SYCL][COMPAT] Memory Header cleanup #13143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2024
Merged

[SYCL][COMPAT] Memory Header cleanup #13143

merged 1 commit into from
Apr 9, 2024

Conversation

Alcpz
Copy link
Contributor

@Alcpz Alcpz commented Mar 25, 2024

This PR cleanses up a the memory header to prepare for the next update:

  • device_memory wrapper now accepts a queue argument (to be consistent with the rest of the memory calls)
  • read_only usm property protected behind a feature macro
  • removed syclcompat:: verbosity from some internal implementations
  • Doxygen docs reviewed
  • Variable names improved (M -> Mem, D -> Dim, Val -> Value)

@Alcpz Alcpz requested a review from a team as a code owner March 25, 2024 12:56
@Alcpz Alcpz force-pushed the Alcpz/memory-header-cleanup branch from 8ac6675 to 2322150 Compare March 25, 2024 13:01
AidanBeltonS
AidanBeltonS approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@AidanBeltonS AidanBeltonS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor LGTM

@Alcpz Alcpz temporarily deployed to WindowsCILock March 25, 2024 13:26 — with GitHub Actions Inactive
@Alcpz Alcpz temporarily deployed to WindowsCILock March 25, 2024 15:53 — with GitHub Actions Inactive
@Alcpz Alcpz temporarily deployed to WindowsCILock March 25, 2024 16:30 — with GitHub Actions Inactive
@Alcpz Alcpz closed this Apr 2, 2024
@Alcpz Alcpz reopened this Apr 2, 2024
@Alcpz Alcpz temporarily deployed to WindowsCILock April 2, 2024 10:19 — with GitHub Actions Inactive
@Alcpz Alcpz temporarily deployed to WindowsCILock April 2, 2024 11:09 — with GitHub Actions Inactive
@Alcpz Alcpz force-pushed the Alcpz/memory-header-cleanup branch from 2322150 to 59ddee1 Compare April 9, 2024 08:46
@Alcpz Alcpz temporarily deployed to WindowsCILock April 9, 2024 08:46 — with GitHub Actions Inactive
@Alcpz Alcpz temporarily deployed to WindowsCILock April 9, 2024 09:06 — with GitHub Actions Inactive
@Alcpz
Copy link
Contributor Author

Alcpz commented Apr 9, 2024

@intel/llvm-gatekeepers PR ready for merging. Thanks!

@sommerlukas sommerlukas merged commit d8c0a93 into intel:sycl Apr 9, 2024
@Alcpz Alcpz deleted the Alcpz/memory-header-cleanup branch June 3, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AidanBeltonS AidanBeltonS AidanBeltonS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alcpz @AidanBeltonS @sommerlukas