Skip to content

[CI] Add IGC dev as new dependency #13184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2024
Merged

[CI] Add IGC dev as new dependency #13184

merged 1 commit into from
Mar 29, 2024

Conversation

jsji
Copy link
Contributor

@jsji jsji commented Mar 27, 2024 •
edited
Loading

This is the 1st PR in prepare of enabling dev IGC test for some of the
SYCL tests.

Ref: #11552

Tested https://github.com/intel/llvm/actions/runs/8461815185/job/23182202059

@jsji jsji self-assigned this Mar 27, 2024
@jsji jsji temporarily deployed to WindowsCILock March 27, 2024 22:07 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 27, 2024 •
edited
Loading

✅ With the latest revision this PR passed the Python code formatter.

@jsji jsji temporarily deployed to WindowsCILock March 27, 2024 22:20 — with GitHub Actions Inactive
@jsji jsji temporarily deployed to WindowsCILock March 27, 2024 23:11 — with GitHub Actions Inactive
@jsji jsji temporarily deployed to WindowsCILock March 27, 2024 23:23 — with GitHub Actions Inactive
@jsji
[CI] Add IGC dev as new dependency
7c310a9 
This is the 1st PR in prepare of enabling dev IGC test for some of the
t stSYCL tests.

Ref: intel#11552
@jsji jsji marked this pull request as ready for review March 28, 2024 03:10
@jsji jsji requested a review from a team as a code owner March 28, 2024 03:10
@jsji jsji mentioned this pull request Mar 28, 2024
Closed
@jsji
Copy link
Contributor Author

jsji commented Mar 29, 2024

Thanks @cperkinsintel . @intel/llvm-gatekeepers Can you please merge this? Thanks.

@aelovikov-intel aelovikov-intel merged commit 2f03ef8 into intel:sycl Mar 29, 2024
@aelovikov-intel
Copy link
Contributor

@jsji , https://github.com/intel/llvm/actions/runs/8485593107 has failed after this. Is that expected?

@jsji
Copy link
Contributor Author

jsji commented Mar 29, 2024 •
edited
Loading

@jsji , https://github.com/intel/llvm/actions/runs/8485593107 has failed after this. Is that expected?

pushing ghcr.io/intel/llvm/ubuntu2204_base:2f03ef85fee5e867c8250d535f561f2e52e5260c with docker:

ERROR: denied: installation not allowed to Write organization package
Error: buildx failed with: ERROR: denied: installation not allowed to Write organization package

I think it is more related to the permission change in #13173
, just exposed by this? This change hasn't touched any of the docker image build yet.

@aelovikov-intel
Copy link
Contributor

I think it is more related to the permission change in #13173, just exposed by this? This change hasn't touched any of the docker image build yet.

@jsji
Copy link
Contributor Author

jsji commented Mar 29, 2024

@stdale-intel https://github.com/intel/llvm/pull/13173/files#diff-93e4ff9c5dcc4dfae5e351c7217e250a2f31e0622e4ca77f0926eba1dceaaadfR24 I think we should allow write in sycl-container.yaml as we are doing push after image update.

@jsji
Copy link
Contributor Author

jsji commented Apr 2, 2024

@stdale-intel https://github.com/intel/llvm/pull/13173/files#diff-93e4ff9c5dcc4dfae5e351c7217e250a2f31e0622e4ca77f0926eba1dceaaadfR24 I think we should allow write in sycl-container.yaml as we are doing push after image update.

#13245 Posted to fix the permission issue.

@stdale-intel
Copy link
Contributor

@jsji thank you, I was working on a PR to fix this and a few other permissions errors that came up after the change. Thanks for doing this one, i'll remove it from my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cperkinsintel cperkinsintel cperkinsintel approved these changes

Assignees

@jsji jsji

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsji @aelovikov-intel @stdale-intel @cperkinsintel