Skip to content

[SYCL] Remove deprecated shuffles from the sub-group class #13236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2024
Merged

[SYCL] Remove deprecated shuffles from the sub-group class #13236

merged 1 commit into from
Apr 2, 2024

Conversation

aelovikov-intel
Copy link
Contributor

No description provided.

@aelovikov-intel aelovikov-intel requested a review from a team as a code owner April 1, 2024 22:06
maarquitos14
maarquitos14 approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aelovikov-intel aelovikov-intel added the abi-break change that's breaking abi and waiting for the next window to be able to merge label Apr 2, 2024
@aelovikov-intel aelovikov-intel merged commit e9b0e60 into intel:sycl Apr 2, 2024
@aelovikov-intel aelovikov-intel deleted the deprecated-sg-shuffle branch April 2, 2024 16:55
aelovikov-intel added a commit that referenced this pull request Apr 17, 2024
@aelovikov-intel
Revert "[SYCL] Remove deprecated shuffles from the sub-group class (#…
42641d2 
…13236)"

This reverts commit e9b0e60.
@aelovikov-intel aelovikov-intel mentioned this pull request Apr 17, 2024
Merged
aelovikov-intel added a commit that referenced this pull request Apr 18, 2024
@aelovikov-intel
Revert "[SYCL] Remove deprecated shuffles from the sub-group class" (#…
169b690 
…13463)

Reverts #13236
@aelovikov-intel aelovikov-intel mentioned this pull request May 6, 2024
Merged
aelovikov-intel added a commit that referenced this pull request Jun 28, 2024
@aelovikov-intel
[SYCL] Remove deprecated shuffles from the sub-group class (#13666)
c9842c1 
Re-lands #13236 and reverts
#13463.
@ianayl ianayl mentioned this pull request Jul 18, 2024
Merged
sommerlukas pushed a commit that referenced this pull request Jul 26, 2024
@ianayl
[SYCL][E2E][NFC] Remove obsolete shuffles.hpp from subgroups tests (#…
03edba6 
…14649)

The only test cases using `test-e2e/SubGroup/shuffle.hpp` was deleted in
#13236, so this is no longer needed. Either way, the header references
the `sub_group.shuffle` function, which no longer exists in intel/llvm
anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maarquitos14 maarquitos14 maarquitos14 approved these changes

Assignees
No one assigned
Labels
abi-break change that's breaking abi and waiting for the next window to be able to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aelovikov-intel @maarquitos14