[SYCL][HIP] Update amd joint_matrix tests to reflect changes to joint_matrix_mad API. #13250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmoadeli
changed the title
frasercrmck
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
LGTM.
Note that this and #13226 depend on one another; depending on which is merged first, the uses of _be will have to be removed from the other.
Yep one of these will need to be rebased on whichever one merges first |
|
#13226 has just merged so you can revert the |
hdelan
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
joint_matrix_madAPI has been modified to accept the output as an argument to the function. This pull request updates the relevant tests to accommodate this change for amd gpu.