[SYCL] Implement latest version of sycl_ext_oneapi_free_function_queries #13257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
- Implement latest revision of the proposed extension - Deprecate `sycl::ext::oneapi::experimental::` interfaces - Remove old deprecated interfaces from `sycl::` namespace
aelovikov-intel
force-pushed
the
free-function-queries
branch
from
d143fad to
66b21e8
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
bader
reviewed
Apr 2, 2024
sycl/test/basic_tests/free_function_queries/free_function_queries_interface.cpp
Outdated
Show resolved
Hide resolved
Alcpz
approved these changes
Apr 3, 2024
gmlueck
reviewed
Apr 3, 2024
Pennycook
reviewed
Apr 3, 2024
Comment on lines
93
to
98
| namespace this_kernel { | ||
| template <int Dimensions> root_group<Dimensions> get_root_group() { | ||
| return this_nd_item<Dimensions>().ext_oneapi_get_root_group(); | ||
| return sycl::ext::oneapi::this_work_item::this_nd_item<Dimensions>() | ||
| .ext_oneapi_get_root_group(); | ||
| } | ||
| } // namespace this_kernel |
There was a problem hiding this comment.
Just a note: We should update the root_group extension, too. This function should be defined as this_work_item::get_root_group() to match the others.
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
gmlueck
approved these changes
Apr 3, 2024
aelovikov-intel
added
the
abi-break
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
v-klochkov
approved these changes
Apr 4, 2024
|
ping @KseniyaTikhomirova , @intel/llvm-reviewers-runtime |
KseniyaTikhomirova
approved these changes
Apr 4, 2024
| results_acc[0] = that_nd_item == nd_i; | ||
| auto nd_item_group = that_nd_item.get_group(); | ||
| results_acc[1] = | ||
| nd_item_group == sycl::ext::oneapi::experimental::this_group<1>(); | ||
| nd_item_group == | ||
| sycl::ext::oneapi::this_work_item::get_work_group<1>(); | ||
| auto nd_item_id = that_nd_item.get_global_id(); | ||
| results_acc[2] = | ||
| nd_item_id == sycl::ext::oneapi::experimental::this_id<1>(); |
There was a problem hiding this comment.
"this_id" usage - should it be updated too?
There was a problem hiding this comment.
No, these are deprecated interfaces and don't have corresponding overloads in the new spec.
There was a problem hiding this comment.
should it be removed then?
There was a problem hiding this comment.
The extension specification marks them as deprecated without providing an alternative. That is part of the change in this PR. We will only be able to remove 2025.1 or later.
This was referenced Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sycl::ext::oneapi::experimental::interfacessycl::namespace