Skip to content

[DeviceSanitizer] Strip off pointer casts and inbounds GEPs #13262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

zhaomaosu
Copy link
Contributor

@zhaomaosu zhaomaosu commented Apr 3, 2024

Disable device sanitizer instrument following case:
%0 = load i64, ptr addrspace(1) getelementptr inbounds (i8,
ptr addrspace(1) @__spirv_BuiltInGlobalInvocationId, i64 8)

@zhaomaosu zhaomaosu requested a review from a team as a code owner April 3, 2024 08:04
@zhaomaosu zhaomaosu requested review from AllanZyne and wenju-he April 3, 2024 08:04
@zhaomaosu zhaomaosu requested review from yingcong-wu and jinge90 April 3, 2024 08:04
Copy link
Contributor

@wenju-he wenju-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a example in pr description?

@zhaomaosu
Copy link
Contributor Author

could you add a example in pr description?

Done, also added a lit test.

Copy link
Contributor

@wenju-he wenju-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AllanZyne
Copy link
Contributor

Just a side note, I added this in #13247 as well

@zhaomaosu
Copy link
Contributor Author

Hi @intel/llvm-gatekeepers, could you please help merge this PR? Thanks.

@steffenlarsen steffenlarsen merged commit 13a80f8 into intel:sycl Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants