-
Notifications
You must be signed in to change notification settings - Fork 788
[CI] Enable running tests with dev igc driver w label #13305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Developers can choose the docker image by label. Ref: #11552
Please change manual dispatch in https://github.com/intel/llvm/blob/sycl/.github/workflows/sycl-linux-run-tests.yml instead. That's what we use for experiments. |
Yes, that will be done in another PR -- to enable doing This PR is to enable running tests for any sycl changes using installed docker image. |
I don't think we should be allowing multiple versions of pre-commit. |
oh, do you mean adding more image options in
|
Why not? HW resource limitation again? |
Yes
Because if one does non-default pre-commit, gets green results, and gatekeepers merge based on that, then it's not verified that the default pre-commit won't get broken by all other people. |
This is true, I will fix it to ensure the workflow won't be green if non default are run. |
Close this first for now per offline discussion with @aelovikov-intel. Use #13380 instead. |
Developers can choose the docker image by label.
There are a few failures when using igc-dev build, we will need to investigate and fix them first before turning on it by default for joint matrix, but this can be merged first so that we can test using ci + label when needed.
Ref: #11552