Skip to content

[CI] Enable running tests with dev igc driver w label #13305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

jsji
Copy link
Contributor

@jsji jsji commented Apr 5, 2024

Developers can choose the docker image by label.

There are a few failures when using igc-dev build, we will need to investigate and fix them first before turning on it by default for joint matrix, but this can be merged first so that we can test using ci + label when needed.

Ref: #11552

Developers can choose the docker image by label.

Ref: #11552
@jsji jsji self-assigned this Apr 5, 2024
@jsji jsji added the ci-no-devigc Do NOT use IGC dev driver in CI for Matrix e2e tests label Apr 5, 2024
@jsji jsji closed this Apr 5, 2024
@jsji jsji reopened this Apr 5, 2024
@jsji jsji closed this Apr 9, 2024
@jsji jsji reopened this Apr 9, 2024
@jsji jsji removed the ci-no-devigc Do NOT use IGC dev driver in CI for Matrix e2e tests label Apr 9, 2024
@jsji jsji closed this Apr 9, 2024
@jsji jsji reopened this Apr 9, 2024
@jsji jsji marked this pull request as ready for review April 10, 2024 03:34
@jsji jsji requested a review from a team as a code owner April 10, 2024 03:34
@aelovikov-intel
Copy link
Contributor

Please change manual dispatch in https://github.com/intel/llvm/blob/sycl/.github/workflows/sycl-linux-run-tests.yml instead. That's what we use for experiments.

@jsji
Copy link
Contributor Author

jsji commented Apr 10, 2024

Please change manual dispatch in https://github.com/intel/llvm/blob/sycl/.github/workflows/sycl-linux-run-tests.yml instead. That's what we use for experiments.

Yes, that will be done in another PR -- to enable doing install_driver test with dev igc when there are driver update.

This PR is to enable running tests for any sycl changes using installed docker image.

@aelovikov-intel
Copy link
Contributor

This PR is to enable running tests for any sycl changes using installed docker image.

I don't think we should be allowing multiple versions of pre-commit.

@jsji
Copy link
Contributor Author

jsji commented Apr 10, 2024

Please change manual dispatch in https://github.com/intel/llvm/blob/sycl/.github/workflows/sycl-linux-run-tests.yml instead. That's what we use for experiments.

oh, do you mean adding more image options in

- 'ghcr.io/intel/llvm/sycl_ubuntu2204_nightly:latest'

@jsji
Copy link
Contributor Author

jsji commented Apr 10, 2024

I don't think we should be allowing multiple versions of pre-commit.

Why not? HW resource limitation again?

@aelovikov-intel
Copy link
Contributor

do you mean adding more image options in

Yes

Why not? HW resource limitation again?

Because if one does non-default pre-commit, gets green results, and gatekeepers merge based on that, then it's not verified that the default pre-commit won't get broken by all other people.

@jsji
Copy link
Contributor Author

jsji commented Apr 10, 2024

Because if one does non-default pre-commit, gets green results, and gatekeepers merge based on that, then it's not verified that the default pre-commit won't get broken by all other people.

This is true, I will fix it to ensure the workflow won't be green if non default are run.

@jsji
Copy link
Contributor Author

jsji commented Apr 12, 2024

Close this first for now per offline discussion with @aelovikov-intel. Use #13380 instead.

@jsji jsji closed this Apr 12, 2024
@jsji jsji deleted the labeltest branch April 23, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants