Skip to content

[Driver][SYCL][FPGA] generated dep files for AOT should be picked up … #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 24, 2020

Conversation

mdtoguchi
Copy link
Contributor

…in CWD

When adding the .d files to be picked up by the aoc tool call, the generated
.d files are created in CWD when the input file is in CWD/dir/file.cpp. This
was wrong where we assumed generation was in CWD/dir

Signed-off-by: Michael D Toguchi [email protected]

…in CWD

When adding the .d files to be picked up by the aoc tool call, the generated
.d files are created in CWD when the input file is in CWD/dir/file.cpp.  This
was wrong where we assumed generation was in CWD/dir

Signed-off-by: Michael D Toguchi <[email protected]>
Signed-off-by: Michael D Toguchi <[email protected]>
@meiyacha
Copy link

…in CWD

When adding the .d files to be picked up by the aoc tool call, the generated
.d files are created in CWD when the input file is in CWD/dir/file.cpp. This
was wrong where we assumed generation was in CWD/dir

Signed-off-by: Michael D Toguchi [email protected]

Isn't the proper solution to make the .d file temporary?

@meiyacha meiyacha closed this Mar 17, 2020
@meiyacha meiyacha reopened this Mar 17, 2020
@mdtoguchi
Copy link
Contributor Author

…in CWD
When adding the .d files to be picked up by the aoc tool call, the generated
.d files are created in CWD when the input file is in CWD/dir/file.cpp. This
was wrong where we assumed generation was in CWD/dir
Signed-off-by: Michael D Toguchi [email protected]

Isn't the proper solution to make the .d file temporary?

It is the solution moving forward (and I left a comment in the code in regards to this) but I wanted to address this now at least for the next release as the fix is not as involved.

Copy link

@meiyacha meiyacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@mdtoguchi
Copy link
Contributor Author

@AGindinson, any input on this one?

Copy link
Contributor

@AGindinson AGindinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response.
The changes mostly LGTM. My only concern is: what would the behavior be if the user specified the output report destination themselves via -Xsycl-target-backend? Is this something that should be handled?

AGindinson
AGindinson previously approved these changes Mar 23, 2020
Copy link
Contributor

@AGindinson AGindinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'm starting to think that it would be a good idea to implement more E2E tests for the FPGA flow in the SYCL RT LIT infrastructure. This could guard us better against undesired UX issues. Coupled with a potential documentation improvement, this could make stuff easier to grasp, for our own benefit.

Signed-off-by: Michael D Toguchi <[email protected]>
@romanovvlad romanovvlad merged commit 91e9c76 into intel:sycl Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants