Skip to content

[SYCL] Remove preview guard from a few tests #13384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// RUN: %clangxx -fsycl -fsyntax-only -Xclang -verify %s -I %sycl_include
// RUN: %if preview-breaking-changes-supported %{%clangxx -fsycl -fsyntax-only -Xclang -verify %s -I %sycl_include -fpreview-breaking-changes -DPREVIEW_BREAKING_CHANGES%}
// RUN: %if preview-breaking-changes-supported %{ %clangxx -fsycl -fsyntax-only -Xclang -verify %s -I %sycl_include -fpreview-breaking-changes %}
// expected-no-diagnostics
//==--------------- handler_generic_lambda_interface.cpp -------------------==//
//
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// RUN: %clangxx -fsycl -fsyntax-only -ferror-limit=0 -Xclang -verify -Xclang -verify-ignore-unexpected=note,warning,error %s
// RUN: %if preview-breaking-changes-supported %{%clangxx -fsycl -fpreview-breaking-changes -fsyntax-only -ferror-limit=0 -Xclang -verify -Xclang -verify-ignore-unexpected=note,warning,error %s -DPREVIEW_BREAKING_CHANGES%}
// RUN: %if preview-breaking-changes-supported %{%clangxx -fsycl -fpreview-breaking-changes -fsyntax-only -ferror-limit=0 -Xclang -verify -Xclang -verify-ignore-unexpected=note,warning,error %s %}

// Tests the requirements on the first argument in a kernel lambda.
// TODO: Some of the behavior is currently guarded behind the
Expand All @@ -19,8 +19,6 @@ template <int Dims> struct ConvertibleFromNDItem {
int main() {
sycl::queue Q;

// TODO: Remove this when the guarded behavior is promoted.
#ifdef PREVIEW_BREAKING_CHANGES
// ND-range parallel_for with item.
Q.submit([&](sycl::handler &CGH) {
// expected-error@sycl/handler.hpp:* {{Kernel argument of a sycl::parallel_for with sycl::nd_range must be either sycl::nd_item or be convertible from sycl::nd_item}}
Expand Down Expand Up @@ -88,7 +86,6 @@ int main() {
CGH.parallel_for(sycl::range{1}, [=](sycl::item<1> it, sycl::item<1> it,
kernel_handler kh) {});
});
#endif // PREVIEW_BREAKING_CHANGES

// Range parallel_for with nd_item.
Q.submit([&](sycl::handler &CGH) {
Expand Down