-
Notifications
You must be signed in to change notification settings - Fork 790
[SYCL] Implement forward_progress extension API #13389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
2cfefb2
Implement forward_progress extension API
lbushi25 b399539
Fix formatting and warnings
lbushi25 722b12b
Fix formatting and warnings
lbushi25 5e8df26
Fix formatting and warnings
lbushi25 17e6ac2
Fix formatting and warnings
lbushi25 2152a4e
Formatting
lbushi25 13d0ff9
Merge branch 'intel:sycl' into ext_forward_progress
lbushi25 096641b
Merge branch 'intel:sycl' into ext_forward_progress
lbushi25 cdaf0e6
Formatting
lbushi25 005a43c
Add new symbols to symbol dump
lbushi25 d97dccd
Add symbols
lbushi25 f49ed0d
Add symbols to symbol dump
lbushi25 a2337bf
Merge branch 'intel:sycl' into ext_forward_progress
lbushi25 bca9f23
Fix namespace declaration issue
lbushi25 f125075
Fix namespace issues
lbushi25 ab760d8
Run clang-format
lbushi25 8cd12e9
Refactor repeated code
lbushi25 eb84eda
Refactor repeated code
lbushi25 7ac944f
Format device_info.hpp
lbushi25 7736042
Add windows symbols and format
lbushi25 5d70a62
Formatting
lbushi25 9063aa7
Refactor tests for readability
lbushi25 9cbbe8a
Partially implement sycl_ext_oneapi_launch_queries
lbushi25 00c1f9e
Implement launch queries for forward progress guarantees
lbushi25 129d28e
Delete sycl/include/sycl/ext/oneapi/kernel_launch_queries.hpp
lbushi25 5272f6b
Update pi.h
lbushi25 fce0519
Update kernel.hpp
lbushi25 6fdae4e
Update kernel.hpp
lbushi25 22adb8a
Delete sycl/test/kernel_param/forward_progress.cpp
lbushi25 86af6b3
Refactor device_impl.hpp and device_info.hpp
lbushi25 cf11c6b
Merge branch 'intel:sycl' into ext_forward_progress
lbushi25 689db34
Refactor handler.hpp and add tests
lbushi25 2c90bed
Update handler.hpp
lbushi25 f50e3de
Update handler.hpp
lbushi25 a01298e
Merge branch 'sycl' into ext_forward_progress
lbushi25 505e011
Update device_impl.cpp
lbushi25 791e872
Update device_impl.cpp
lbushi25 ff62ae8
Update handler.hpp
lbushi25 f91f888
Update handler.hpp
lbushi25 8e78fda
Update handler.hpp
lbushi25 b9c25a9
Add ABI symbols
lbushi25 04019d9
Remove static_assert in favor of runtime assert
lbushi25 264d766
Enable cooperative launch to provide concurrent guarantee
lbushi25 c62cca8
Resolve conflict
lbushi25 cddc56d
Fix failing precomit tests and modify ABI symbols
lbushi25 eaceb69
Fix missing include
lbushi25 f151c4f
Enable cooperative launch of kernel to provide concurrent forward pro…
lbushi25 a43ff24
Merge branch 'intel:sycl' into ext_forward_progress
lbushi25 711146e
Add comments for better explanation
lbushi25 ac28019
Format and change some naming to camelcase
lbushi25 c3dfbe5
Update device_info.hpp
lbushi25 f0d49a5
Align begin/closure lines
lbushi25 43a6d1f
Remove tests to E2E directory
lbushi25 ea3e2d2
Fix small type in forward_progress_kernel_parap_L0_gpu.cpp
lbushi25 934c5b4
Merge branch 'sycl' into ext_forward_progress
lbushi25 f783279
Remove forward_progress include from sycl.hpp
lbushi25 6feef0c
Simplify logic for verifying kernel properties in handler class
lbushi25 5705730
Include forward_progress.hpp in sycl.hpp to conform with the spec
lbushi25 7ede8c3
Run formatter on sycl.hpp
lbushi25 c07088a
Update sycl.hpp
lbushi25 9d88508
Update sycl.hpp
lbushi25 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
sycl/include/sycl/ext/oneapi/experimental/forward_progress.hpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
//==------- forward_progress.hpp - sycl_ext_oneapi_forward_progress -------===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#pragma once | ||
|
||
namespace sycl { | ||
inline namespace _V1 { | ||
namespace ext { | ||
namespace oneapi { | ||
namespace experimental { | ||
|
||
enum class forward_progress_guarantee { concurrent, parallel, weakly_parallel }; | ||
|
||
enum class execution_scope { | ||
work_item, | ||
sub_group, | ||
work_group, | ||
root_group, | ||
}; | ||
|
||
} // namespace experimental | ||
} // namespace oneapi | ||
} // namespace ext | ||
} // namespace _V1 | ||
} // namespace sycl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: CamelCase as for other parameters