Skip to content

[CI] Add cron job to update IGC dev driver only #13412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[CI] Add cron job to update IGC dev driver only #13412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion .github/workflows/sycl-update-gpu-driver.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,13 @@ name: Update GPU driver
on:
schedule:
- cron: '0 3 * * 2'
- cron: '0 3 * * 1,4'
workflow_dispatch:
inputs:
dayofweek:
description: 'Override the day of the week (e.g., 1 for Monday, 2 for Tuesday, etc.)'
required: false
default: '2'

permissions: read-all

Expand All @@ -15,9 +21,25 @@ jobs:
if: github.repository == 'intel/llvm'
steps:
- uses: actions/checkout@v4
- name: Determine parameters based on the day of the week
run: |
if [ "${{ github.event_name }}" = "workflow_dispatch" ]; then
# Use the input dayofweek when manually triggered
DAY_OF_WEEK="${{ github.event.inputs.dayofweek }}"
else
# Use the current day of the week when triggered by a schedule
DAY_OF_WEEK=$(date +%u)
fi

if [ "$DAY_OF_WEEK" = "2" ]; then
PARAM=""
else
PARAM="--igc-dev-only"
fi
echo "PARAM=$PARAM" >> $GITHUB_ENV
Comment on lines +24 to +39
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this. I'd rather move common part into a re-usable workflow and then have two separate cron jobs in distinct .yml files. Also, why can't we just run the existing job frequently enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running existing job freq enough is also ok, but considering the situation of "red" CI -- it might not be realistic to push all driver update more than once per week.
But sure, I am more than happy to do so if we want to try updating ALL drivers more than once a week.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reason we do it once a week is simply because released version aren't updated that frequently and we wanted to avoid running unnecessary task. That said, if nothing is there to update, it should be very fast, so I don't see any reasons for us not to do that.

+ @bader maybe?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right. NEO driver was released one a week in the past. These days, NEO release cadence is once a month.

- name: Update dependencies file
run: |
version="$(python3 devops/scripts/update_drivers.py linux)"
version="$(python3 devops/scripts/update_drivers.py $PARAM linux)"
echo 'NEW_DRIVER_VERSION='$version >> $GITHUB_ENV
- name: Create Pull Request
env:
Expand Down
39 changes: 25 additions & 14 deletions devops/scripts/update_drivers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import sys
import os
import re
import argparse


def get_latest_release(repo):
Expand All @@ -28,7 +29,20 @@ def get_artifacts_download_url(repo, name):
return json.loads(artifacts)["artifacts"][0]["archive_download_url"]


def uplift_linux_igfx_driver(config, platform_tag):
def uplift_linux_igfx_driver(config, platform_tag,igc_dev_only):

igc_dev = get_latest_workflow_runs("intel/intel-graphics-compiler", "build-IGC")
igcdevver = igc_dev["head_sha"][:7]
config[platform_tag]["igc_dev"]["github_tag"] = "igc-dev-" + igcdevver
config[platform_tag]["igc_dev"]["version"] = igcdevver
config[platform_tag]["igc_dev"]["updated_at"] = igc_dev["updated_at"]
config[platform_tag]["igc_dev"]["url"] = get_artifacts_download_url(
"intel/intel-graphics-compiler", "IGC_Ubuntu22.04_llvm14_clang-" + igcdevver
)

if(igc_dev_only):
return config

compute_runtime = get_latest_release('intel/compute-runtime')

config[platform_tag]['compute_runtime']['github_tag'] = compute_runtime['tag_name']
Expand All @@ -46,15 +60,6 @@ def uplift_linux_igfx_driver(config, platform_tag):
config[platform_tag]['igc']['url'] = 'https://github.com/intel/intel-graphics-compiler/releases/tag/igc-' + ver
break

igc_dev = get_latest_workflow_runs("intel/intel-graphics-compiler", "build-IGC")
igcdevver = igc_dev["head_sha"][:7]
config[platform_tag]["igc_dev"]["github_tag"] = "igc-dev-" + igcdevver
config[platform_tag]["igc_dev"]["version"] = igcdevver
config[platform_tag]["igc_dev"]["updated_at"] = igc_dev["updated_at"]
config[platform_tag]["igc_dev"]["url"] = get_artifacts_download_url(
"intel/intel-graphics-compiler", "IGC_Ubuntu22.04_llvm14_clang-" + igcdevver
)

cm = get_latest_release('intel/cm-compiler')
config[platform_tag]['cm']['github_tag'] = cm['tag_name']
config[platform_tag]['cm']['version'] = cm['tag_name'].replace('cmclang-', '')
Expand All @@ -68,22 +73,28 @@ def uplift_linux_igfx_driver(config, platform_tag):
return config


def main(platform_tag):
def main(platform_tag, igc_dev_only):
script = os.path.dirname(os.path.realpath(__file__))
config_name = os.path.join(script, '..', 'dependencies.json')
config = {}

with open(config_name, "r") as f:
config = json.loads(f.read())
config = uplift_linux_igfx_driver(config, platform_tag)
config = uplift_linux_igfx_driver(config, platform_tag, igc_dev_only)

with open(config_name, "w") as f:
json.dump(config, f, indent=2)
f.write('\n')

if(igc_dev_only):
return config[platform_tag]["igc_dev"]["github_tag"]

return config[platform_tag]['compute_runtime']['version']


if __name__ == '__main__':
platform_tag = sys.argv[1] if len(sys.argv) > 1 else "ERROR_PLATFORM"
sys.stdout.write(main(platform_tag) + '\n')
parser = argparse.ArgumentParser()
parser.add_argument('platform_tag')
parser.add_argument('--igc-dev-only', action='store_true')
args = parser.parse_args()
sys.stdout.write(main(args.platform_tag, args.igc_dev_only) + '\n')