[SYCL][ESIMD] Move rdtsc function out of experimental namespace #13417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarnex
reviewed
Apr 16, 2024
| detail::is_esimd_scalar<TArg>::value, | ||
| TRes> | ||
| ESIMD_NODEBUG | ||
| ESIMD_INLINE std::enable_if_t<detail::is_esimd_scalar<TRes>::value && |
There was a problem hiding this comment.
nit: there are some whitespace changes of this pattern that in my opinion decrease readability, i would expect we only need to touch the rdtsc function and not these
| @@ -1302,6 +1301,13 @@ __ESIMD_API uint32_t subb(uint32_t &borrow, uint32_t src0, uint32_t src1) { | |||
| return Res[0]; | |||
| } | |||
|
|
|||
| /// rdtsc - get the value of timestamp counter. | |||
| /// \return the current value of timestamp counter | |||
There was a problem hiding this comment.
I think it's @return based on other functions
| @@ -41,9 +41,9 @@ int test_rdtsc() { | |||
| auto Kernel = ([=](sycl::nd_item<1> ndi) [[intel::sycl_explicit_simd]] { | |||
| using namespace sycl::ext::intel::esimd; | |||
| auto Idx = ndi.get_global_id(0); | |||
| uint64_t StartCounter = sycl::ext::intel::experimental::esimd::rdtsc(); | |||
There was a problem hiding this comment.
nit: maybe we call both experimental and non-experimental based on Idx % 2 or something
v-klochkov
reviewed
Apr 17, 2024
There was a problem hiding this comment.
Looks good to me.
Can you please check if this extension is ready for usage, maybe create a copy/draft of this PR with OpReadClockKHR
v-klochkov
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.