Skip to content

[CI][SYCL-CTS] Ensure link/test runs are parallel #13533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 25, 2024
Merged

[CI][SYCL-CTS] Ensure link/test runs are parallel #13533

merged 8 commits into from
Apr 25, 2024

Conversation

aelovikov-intel
Copy link
Contributor

@aelovikov-intel aelovikov-intel commented Apr 23, 2024 •
edited
Loading

#13421 reduced parellization when trying to avoid early build failouts. Use ninja's -k0 to do the same without undesired side effects. Also run individual tests in parallel as well.

@aelovikov-intel
[CI][SYCL-CTS] Ensure link is parallel
6685358 
#13421 reduced parellization when
trying to avoid early build failouts. Use `ninja`'s `-k0` to do the same
without undesired side effects.
@aelovikov-intel aelovikov-intel requested a review from a team as a code owner April 23, 2024 17:36
KornevNikita
KornevNikita approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@KornevNikita KornevNikita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely much better, but it would be helpful to have a list of failed to build categories in the summary. Anyway, it may be tricky, so we can left it for the future.

@aelovikov-intel aelovikov-intel marked this pull request as draft April 23, 2024 21:52
@KornevNikita
Copy link
Contributor

BTW - there is a "test_conformance" target to build all except test_all: KhronosGroup/SYCL-CTS@1aba52f

@aelovikov-intel aelovikov-intel changed the title [CI][SYCL-CTS] Ensure link is parallel [CI][SYCL-CTS] Ensure link/test runs are parallel Apr 24, 2024
@aelovikov-intel
Copy link
Contributor Author

Manual testing runs:
https://github.com/intel/llvm/actions/runs/8820525882/job/24214350497 (just two tests)
https://github.com/intel/llvm/actions/runs/8820553122 (default full run)

@aelovikov-intel aelovikov-intel marked this pull request as ready for review April 24, 2024 17:16
KornevNikita
KornevNikita approved these changes Apr 24, 2024
View reviewed changes
@aelovikov-intel
Copy link
Contributor Author

aelovikov-intel commented Apr 24, 2024 •
edited
Loading

@intel/dpcpp-devops-reviewers this is ready for your review.

@aelovikov-intel
Copy link
Contributor Author

@intel/dpcpp-devops-reviewers this is ready for your review.

@steffenlarsen @cperkinsintel @uditagarwal97 @intel/dpcpp-devops-reviewers , ping x2.

@uditagarwal97
Copy link
Contributor

https://github.com/intel/llvm/actions/runs/8821781116/job/24220570301?pr=13533
I see that SYCL CTS Build and test jobs are skipped. Is that intentional?

@aelovikov-intel
Copy link
Contributor Author

aelovikov-intel commented Apr 25, 2024 •
edited
Loading

https://github.com/intel/llvm/actions/runs/8821781116/job/24220570301?pr=13533 I see that SYCL CTS Build and test jobs are skipped. Is that intentional?

Yes, we only run it in Nightly. Also, it's "either e2e or cts", that particular job was running e2e.

uditagarwal97
uditagarwal97 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aelovikov-intel
Copy link
Contributor Author

Failures are unrelated - they are on e2e and not on cts.

@aelovikov-intel aelovikov-intel merged commit 6f4c745 into sycl Apr 25, 2024
@aelovikov-intel aelovikov-intel deleted the cts-parallel-link branch April 25, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uditagarwal97 uditagarwal97 uditagarwal97 approved these changes

@KornevNikita KornevNikita KornevNikita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aelovikov-intel @KornevNikita @uditagarwal97