Skip to content

[CI] Install driver when doing tests for dependencies-igc-dev.json update #13538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

jsji
Copy link
Contributor

@jsji jsji commented Apr 23, 2024

When we are doing dependencies-igc-dev.json update,
we will rebuild the docker image, but we can't use that image
immediately in the same CI for testing.

So we need to run the test by using the install driver option.

@jsji jsji self-assigned this Apr 23, 2024
@jsji jsji temporarily deployed to WindowsCILock April 23, 2024 21:35 — with GitHub Actions Inactive
@jsji jsji temporarily deployed to WindowsCILock April 23, 2024 21:47 — with GitHub Actions Inactive
@jsji jsji temporarily deployed to WindowsCILock April 24, 2024 02:29 — with GitHub Actions Inactive
@jsji jsji temporarily deployed to WindowsCILock April 24, 2024 03:26 — with GitHub Actions Inactive
@jsji jsji temporarily deployed to WindowsCILock April 24, 2024 03:42 — with GitHub Actions Inactive
@jsji jsji marked this pull request as ready for review April 24, 2024 14:04
@jsji jsji requested a review from a team as a code owner April 24, 2024 14:04
…date

When we are doing dependencies-igc-dev.json update,
we will rebuild the docker image, but we can't use that image
immediately in the same CI for testing.

So we need to run the test by using the install driver option.
@jsji jsji force-pushed the fixigcdevupdateci branch from 1c2e112 to 53faabc Compare April 24, 2024 14:19
@jsji
Copy link
Contributor Author

jsji commented Apr 24, 2024

@@ -57,6 +57,8 @@ jobs:
drivers:
- devops/dependencies.json
- devops/scripts/install_drivers.sh
devigccfg:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it should be

devigccfg: &devigccfg
  - devops/dependencies-igc-dev.json
drivers:
  - *devigccfg
  - devops/dependencies.json
  - devops/scripts/install_drivers.sh

instead, but either way is good enough for now.

@jsji jsji temporarily deployed to WindowsCILock April 24, 2024 20:50 — with GitHub Actions Inactive
@jsji jsji temporarily deployed to WindowsCILock April 24, 2024 21:57 — with GitHub Actions Inactive
@jsji
Copy link
Contributor Author

jsji commented Apr 25, 2024

@intel/llvm-gatekeepers Can you please merge this. Thanks.

@aelovikov-intel aelovikov-intel merged commit 9191ceb into sycl Apr 25, 2024
@aelovikov-intel aelovikov-intel deleted the fixigcdevupdateci branch April 25, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants