[SYCL][CMake] Build sycl-toolchain by default #13550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maarquitos14
approved these changes
Apr 24, 2024
In compile.py we are using -t sycl-toolchain to build the sycl toolchain. However, sycl-toolchain is not added by default target. So when I configure the project , then build the default target, eg: `ninja` some of the libs eg: libdevice will not be built even if they are in the "LLVM_ENABLE_PROJECTS" list. eg: One of the typical failures are missing sycl-devicelib-host. ``` /iusers/jinsongj/llvm/build/bin/clang++ -fsycl -fsycl-targets=spir64 /iusers/jinsongj/llvm/sycl/test-e2e/Matrix/XMX8/element_wise_abc.cpp $ /iusers/jinsongj/llvm/build/bin/clang++ -fsycl -fsycl-targets=spir64 /iusers/jinsongj/llvm/sycl/test-e2e/Matrix/XMX8/element_wise_abc.cpp /usr/bin/ld: cannot find -lsycl-devicelib-host: No such file or directory clang++: error: linker command failed with exit code 1 (use -v to see invocation) ``` So I have to run `ninja sycl-toolchain` again to build sycl toolchain. Since sycl branch is for sycl-toolchain, I think we should enable building sycl-toolchain by default.
|
@intel/llvm-gatekeepers This is ready for merge. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In compile.py we are using -t sycl-toolchain to build the sycl
toolchain. However, sycl-toolchain is not added by default target.
So when I configure the project , then build the default target,
eg:
ninjasome of the libs eg: libdevice will not be built even if they are in the
"LLVM_ENABLE_PROJECTS" list.
eg: One of the typical failures are missing sycl-devicelib-host.
So I have to run
ninja sycl-toolchainagain to build sycl toolchain.Since sycl branch is for sycl-toolchain, I think we should enable
building sycl-toolchain by default.