[SYCL][Driver] Refactor device config parsing to better match HIP and CUDA targets #13617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeWeb
force-pushed
the
georgi/sycl-parse-device-config-cuda-hip
branch
from
b90f317 to
eb6b63b
Compare
GeorgeWeb
force-pushed
the
georgi/sycl-parse-device-config-cuda-hip
branch
from
eb6b63b to
0aaa72d
Compare
… CUDA targets This commit also moves the parsing into SYCLActionBuilder, so it can make use of the device architecture bound to the offloading toolchain to lookup in the DeviceConfig file's TargetTable.
GeorgeWeb
force-pushed
the
georgi/sycl-parse-device-config-cuda-hip
branch
from
0aaa72d to
25785a2
Compare
maarquitos14
reviewed
May 1, 2024
maarquitos14
reviewed
May 1, 2024
maarquitos14
reviewed
May 2, 2024
GeorgeWeb
force-pushed
the
georgi/sycl-parse-device-config-cuda-hip
branch
from
e2097a0 to
ed1e2fe
Compare
AlexeySachkov
approved these changes
May 6, 2024
hchilama
approved these changes
May 6, 2024
…evice-config-cuda-hip
srividya-sundaram
approved these changes
May 10, 2024
|
@intel/llvm-gatekeepers Think this is ready to merge now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the device config parsing by making it agnostic of the way the SYCL device is targeted, either by passing a device triple plus arch special string to
-fsycl-targetsor a just the device arch to--offload-arch(mostly for CUDA and HIP). This is achieved by also moving the parsing logic intoSYCLActionBuilder, in order to make use of the device architecture bound to the offloading toolchain to lookup in the DeviceConfig file's TargetTable accordingly.This PR also introduces HIP and CUDA target info in the
DeviceConfigFile.tdwhich is currently not complete but a starting point to build on.