Skip to content

[MLIR][GPU-LLVM] Define -convert-gpu-to-llvm-spv pass #13640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

[MLIR][GPU-LLVM] Define -convert-gpu-to-llvm-spv pass #13640

wants to merge 8 commits into from

Conversation

victor-eds
Copy link
Contributor

Define pass for GPU to LLVM conversion for SPIR-V backend tool injest.

Supported operations:

  • gpu.block_id
  • gpu.global_id
  • gpu.block_dim
  • gpu.thread_id
  • gpu.grid_dim
  • gpu.barrier
  • gpu.shuffle

@victor-eds
[MLIR][GPU-LLVM] Define -convert-gpu-to-llvm-spv pass
5beebb2 
Define pass for GPU to LLVM conversion for SPIR-V backend tool injest.

Supported operations:

- `gpu.block_id`
- `gpu.global_id`
- `gpu.block_dim`
- `gpu.thread_id`
- `gpu.grid_dim`
- `gpu.barrier`
- `gpu.shuffle`

Signed-off-by: Victor Perez <[email protected]>
@victor-eds victor-eds added the genx Pull requests or issues for genx branch label May 2, 2024
@victor-eds victor-eds self-assigned this May 2, 2024
victor-eds
victor-eds commented May 2, 2024
View reviewed changes
victor-eds
victor-eds commented May 2, 2024
View reviewed changes
etiotto
etiotto reviewed May 2, 2024
View reviewed changes
@victor-eds
Copy link
Contributor Author

@etiotto

I redefined patterns so now populateGpuToLLVMSPVConversionPatterns can work on non-gpu.module. The pass itself is defined that way to follow nvvm and rocdl counterparts, but this is not needed at all.

etiotto
etiotto approved these changes May 2, 2024
View reviewed changes
Copy link

@etiotto etiotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@victor-eds
Couple minors
e648714 
Signed-off-by: Victor Perez <[email protected]>
etiotto
etiotto approved these changes May 3, 2024
View reviewed changes
Copy link

@etiotto etiotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FMarno FMarno mentioned this pull request May 16, 2024
Merged
@whitneywhtsang whitneywhtsang mentioned this pull request May 31, 2024
Merged
@victor-eds
Copy link
Contributor Author

Upstream llvm/llvm-project#90972 merged

@victor-eds victor-eds closed this May 31, 2024
@victor-eds victor-eds deleted the gpu-to-llvm-spv branch May 31, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FMarno FMarno FMarno approved these changes

@whitneywhtsang whitneywhtsang whitneywhtsang approved these changes

@etiotto etiotto etiotto approved these changes

@sommerlukas sommerlukas Awaiting requested review from sommerlukas

Assignees

@victor-eds victor-eds

Labels
genx Pull requests or issues for genx branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@victor-eds @FMarno @whitneywhtsang @etiotto