Skip to content

[SYCL][Docs] Fix variadic properties ctor #13676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2024
Merged

[SYCL][Docs] Fix variadic properties ctor #13676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e43b79
[SYCL][Docs] Fix variadic properties ctor
steffenlarsen May 6, 2024
bf9d3ef
Add link to clang issue.
steffenlarsen May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sycl/doc/extensions/experimental/sycl_ext_oneapi_annotated_arg.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ template <typename T, typename PropertyListT = empty_properties_t>
class annotated_arg {
public:
annotated_arg() noexcept;
annotated_arg(const T& v_, const PropertyListT &P = properties{}) noexcept;
annotated_arg(const T& v_, const PropertyListT &P = PropertyListT{}) noexcept;
template<typename... PropertyValueTs>
annotated_arg(const T& v_, PropertyValueTs... props) noexcept;

Expand Down Expand Up @@ -277,7 +277,7 @@ Constructs an `annotated_arg` object which is default initialized.
a|
[source,c++]
----
annotated_arg(const T& v_, const PropertyListT &P = properties{}) noexcept;
annotated_arg(const T& v_, const PropertyListT &P = PropertyListT{}) noexcept;
----
| Not available in device code.
Constructs an `annotated_arg` object from the input object `v_`.
Expand Down
4 changes: 2 additions & 2 deletions sycl/doc/extensions/experimental/sycl_ext_oneapi_annotated_ptr.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ class annotated_ptr {
using reference = annotated_ref<T, PropertyListT>;

annotated_ptr() noexcept;
explicit annotated_ptr(T *Ptr, const PropertyListT &P = properties{}) noexcept;
explicit annotated_ptr(T *Ptr, const PropertyListT &P = PropertyListT{}) noexcept;
template<typename... PropertyValueTs>
explicit annotated_ptr(T *Ptr, PropertyValueTs... props) noexcept;

Expand Down Expand Up @@ -359,7 +359,7 @@ underlying pointer is initialized to `nullptr`.
a|
[source,c++]
----
explicit annotated_ptr(T *Ptr, const PropertyListT &P = properties{}) noexcept;
explicit annotated_ptr(T *Ptr, const PropertyListT &P = PropertyListT{}) noexcept;
----
|
Constructs an `annotated_ptr` object. Does not allocate new storage. The
Expand Down
64 changes: 32 additions & 32 deletions sycl/doc/extensions/proposed/sycl_ext_oneapi_usm_malloc_properties.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ malloc_device_annotated(
size_t numBytes,
const device& syclDevice,
const context& syclContext,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory, which is allocated on `syclDevice`.
The allocation size is specified in bytes.
Expand Down Expand Up @@ -316,7 +316,7 @@ malloc_device_annotated(
size_t count,
const device& syclDevice,
const context& syclContext,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory, which is allocated on `syclDevice`.
The allocation size is specified in number of elements of type
Expand Down Expand Up @@ -349,7 +349,7 @@ annotated_ptr<void, propertyListB>
malloc_device_annotated(
size_t numBytes,
const queue& syclQueue,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Simplified form where `syclQueue` provides the `device`
and `context`.
Expand All @@ -364,7 +364,7 @@ annotated_ptr<T, propertyListB>
malloc_device_annotated(
size_t count,
const queue& syclQueue,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Simplified form where `syclQueue` provides the `device`
and `context`.
Expand All @@ -379,7 +379,7 @@ aligned_alloc_device_annotated(
size_t numBytes,
const device& syclDevice,
const context& syclContext,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory, which is allocated on
`syclDevice`.
Expand Down Expand Up @@ -417,7 +417,7 @@ aligned_alloc_device_annotated(
size_t count,
const device& syclDevice,
const context& syclContext,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory, which is allocated on
`syclDevice`.
Expand Down Expand Up @@ -452,7 +452,7 @@ aligned_alloc_device_annotated(
size_t alignment,
size_t numBytes,
const queue& syclQueue,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Simplified form where `syclQueue` provides the `device`
and `context`.
Expand All @@ -468,7 +468,7 @@ aligned_alloc_device_annotated(
size_t alignment,
size_t count,
const queue& syclQueue,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Simplified form where `syclQueue` provides the `device`
and `context`.
Expand Down Expand Up @@ -497,7 +497,7 @@ annotated_ptr<void, propertyListB>
malloc_host_annotated(
size_t numBytes,
const context& syclContext,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory. This allocation is specified in bytes.

Expand Down Expand Up @@ -526,7 +526,7 @@ annotated_ptr<T, propertyListB>
malloc_host_annotated(
size_t count,
const context& syclContext,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory. This allocation is specified in number of elements of type `T`.

Expand All @@ -553,7 +553,7 @@ annotated_ptr<void, propertyListB>
malloc_host_annotated(
size_t numBytes,
const queue& syclQueue,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Simplified form where `syclQueue` provides the `context`.

Expand All @@ -567,7 +567,7 @@ annotated_ptr<T, propertyListB>
malloc_host_annotated(
size_t count,
const queue& syclQueue,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Simplified form where `syclQueue` provides the `context`.

Expand All @@ -580,7 +580,7 @@ aligned_alloc_host_annotated(
size_t alignment,
size_t numBytes,
const context& syclContext,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory.
This allocation is specified in bytes and aligned according to `alignment`.
Expand Down Expand Up @@ -611,7 +611,7 @@ aligned_alloc_host_annotated(
size_t alignment,
size_t count,
const context& syclContext,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory.
This allocation is specified in elements of type `T` and aligned according to `alignment`.
Expand Down Expand Up @@ -640,7 +640,7 @@ aligned_alloc_host_annotated(
size_t alignment,
size_t numBytes,
const queue& syclQueue,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Simplified form where `syclQueue` provides the `context`.

Expand All @@ -655,7 +655,7 @@ aligned_alloc_host_annotated(
size_t alignment,
size_t count,
const queue& syclQueue,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Simplified form where `syclQueue` provides the `context`.

Expand Down Expand Up @@ -683,7 +683,7 @@ malloc_shared_annotated(
size_t numBytes,
const device& syclDevice,
const context& syclContext,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory, which is associated with `syclDevice`.
This allocation is specified in bytes.
Expand Down Expand Up @@ -718,7 +718,7 @@ malloc_shared_annotated(
size_t count,
const device& syclDevice,
const context& syclContext,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory, which is associated with `syclDevice`.
This allocation is specified in number of elements of
Expand Down Expand Up @@ -751,7 +751,7 @@ annotated_ptr<void, propertyListB>
malloc_shared_annotated(
size_t numBytes,
const queue& syclQueue,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Simplified form where `syclQueue` provides the `device` and
`context`.
Expand All @@ -766,7 +766,7 @@ annotated_ptr<T, propertyListB>
malloc_shared_annotated(
size_t count,
const queue& syclQueue,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Simplified form where `syclQueue` provides the `device` and
`context`.
Expand All @@ -781,7 +781,7 @@ aligned_alloc_shared_annotated(
size_t numBytes,
const device& syclDevice,
const context& syclContext,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory, which is associated with `syclDevice`.
This allocation is specified in bytes and aligned according to `alignment`.
Expand Down Expand Up @@ -817,7 +817,7 @@ aligned_alloc_shared_annotated(
size_t count,
const device& syclDevice,
const context& syclContext,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory, which is associated with `syclDevice`.
This allocation is specified in number of elements of type `T` and aligned according to `alignment`.
Expand Down Expand Up @@ -850,7 +850,7 @@ aligned_alloc_shared_annotated(
size_t alignment,
size_t numBytes,
const queue& syclQueue,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Simplified form where `syclQueue` provides the `device` and
`context`.
Expand All @@ -866,7 +866,7 @@ aligned_alloc_shared_annotated(
size_t alignment,
size_t count,
const queue& syclQueue,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Simplified form where `syclQueue` provides the `device` and
`context`.
Expand Down Expand Up @@ -907,7 +907,7 @@ malloc_annotated(
const device& syclDevice,
const context& syclContext,
sycl::usm::alloc kind,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory of type `kind`.
This allocation size is specified in bytes.
Expand Down Expand Up @@ -940,7 +940,7 @@ malloc_annotated(
const device& syclDevice,
const context& syclContext,
sycl::usm::alloc kind,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory of type `kind`.
This allocation is specified in number of elements of type `T`.
Expand Down Expand Up @@ -971,7 +971,7 @@ malloc_annotated(
size_t numBytes,
const queue& syclQueue,
sycl::usm::alloc kind,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Simplified form where `syclQueue` provides the `context`
and any necessary `device`.
Expand All @@ -987,7 +987,7 @@ malloc_annotated(
size_t count,
const queue& syclQueue,
sycl::usm::alloc kind,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Simplified form where `syclQueue` provides the `context`
and any necessary `device`.
Expand All @@ -1003,7 +1003,7 @@ aligned_alloc_annotated(
const device& syclDevice,
const context& syclContext,
sycl::usm::alloc kind,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory of type `kind`.
This allocation is specified in bytes and is aligned according to `alignment`.
Expand Down Expand Up @@ -1037,7 +1037,7 @@ aligned_alloc_annotated(
const device& syclDevice,
const context& syclContext,
sycl::usm::alloc kind,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Returns an `annotated_ptr` containing a raw pointer to the newly allocated memory of type `kind`.
This allocation is specified in number of elements of type `T` and is aligned according to `alignment`.
Expand Down Expand Up @@ -1068,7 +1068,7 @@ aligned_alloc_annotated(
size_t numBytes,
const queue& syclQueue,
sycl::usm::alloc kind,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Simplified form where `syclQueue` provides the `context`
and any necessary `device`.
Expand All @@ -1085,7 +1085,7 @@ aligned_alloc_annotated(
size_t count,
const queue& syclQueue,
sycl::usm::alloc kind,
const propertyListA &propList = properties{})
const propertyListA &propList = propertyListA{})
----
a@ Simplified form where `syclQueue` provides the `context`
and any necessary `device`.
Expand Down
4 changes: 2 additions & 2 deletions sycl/include/sycl/ext/oneapi/experimental/annotated_arg/annotated_arg.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ __SYCL_TYPE(annotated_arg) annotated_arg<T *, detail::properties_t<Props...>> {
annotated_arg &operator=(annotated_arg &) = default;

annotated_arg(T *_ptr,
const property_list_t &PropList = properties{}) noexcept
const property_list_t &PropList = property_list_t{}) noexcept
: obj(_ptr) {
(void)PropList;
}
Expand Down Expand Up @@ -250,7 +250,7 @@ __SYCL_TYPE(annotated_arg) annotated_arg<T, detail::properties_t<Props...>> {
annotated_arg &operator=(annotated_arg &) = default;

annotated_arg(const T &_obj,
const property_list_t &PropList = properties{}) noexcept
const property_list_t &PropList = property_list_t{}) noexcept
: obj(_obj) {
(void)PropList;
}
Expand Down
2 changes: 1 addition & 1 deletion sycl/include/sycl/ext/oneapi/experimental/annotated_ptr/annotated_ptr.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ __SYCL_TYPE(annotated_ptr) annotated_ptr<T, detail::properties_t<Props...>> {
annotated_ptr &operator=(const annotated_ptr &) = default;

explicit annotated_ptr(T *Ptr,
const property_list_t & = properties{}) noexcept
const property_list_t & = property_list_t{}) noexcept
: m_Ptr(Ptr) {}

// Constructs an annotated_ptr object from a raw pointer and variadic
Expand Down
Loading