Skip to content

[SYCL][CUDA] Fix support of printf for CUDA backend on Windows. #13784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 28, 2024
Merged

[SYCL][CUDA] Fix support of printf for CUDA backend on Windows. #13784

merged 3 commits into from
May 28, 2024

Conversation

mmoadeli
Copy link
Contributor

@mmoadeli mmoadeli commented May 14, 2024 •
edited
Loading

  • Addresses a build error seen when using printf for CUDA backend on Windows.
  • The mentioned build error can be seen in test-e2e/Basic/built-ins.cpp
  • Remove dead code as printf in SYCL cuda /amd device code calls __builtin_printf

@mmoadeli mmoadeli requested a review from a team as a code owner May 14, 2024 20:41
@mmoadeli mmoadeli requested a review from sergey-semenov May 14, 2024 20:41
@mmoadeli mmoadeli marked this pull request as draft May 14, 2024 20:58
@mmoadeli mmoadeli marked this pull request as ready for review May 14, 2024 21:19
@mmoadeli mmoadeli requested a review from a team as a code owner May 14, 2024 21:19
elizabethandrews
elizabethandrews reviewed May 22, 2024
View reviewed changes
Copy link
Contributor

@elizabethandrews elizabethandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this breaks a frontend test for sycl::ext::oneapi::experimental::printf - CodeGenSYCL/nvptx-printf.cpp

@mmoadeli mmoadeli temporarily deployed to WindowsCILock May 24, 2024 13:25 — with GitHub Actions Inactive
@mmoadeli mmoadeli temporarily deployed to WindowsCILock May 24, 2024 14:01 — with GitHub Actions Inactive
@mmoadeli
Copy link
Contributor Author

Looks like this breaks a frontend test for sycl::ext::oneapi::experimental::printf - CodeGenSYCL/nvptx-printf.cpp

@elizabethandrews thank you. It's sorted.

@ldrumm ldrumm merged commit 704a2a3 into intel:sycl May 28, 2024
13 of 14 checks passed
@mmoadeli mmoadeli deleted the cuda-windows-printf branch June 17, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergey-semenov sergey-semenov sergey-semenov approved these changes

@elizabethandrews elizabethandrews elizabethandrews approved these changes

@smanna12 smanna12 smanna12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmoadeli @sergey-semenov @elizabethandrews @smanna12 @ldrumm