Skip to content

[SYCL][E2E] Add an env var to run on Windows #13822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2024

Conversation

bso-intel
Copy link
Contributor

SYCL_ENABLE_DEFAULT_CONTEXTS=1 is needed to run on Windows.

SYCL_ENABLE_DEFAULT_CONTEXTS=1 is needed to run on Windows.
@bso-intel bso-intel changed the title [SYCL][TEST-E2E] Add an env var to run on Windows [SYCL][E2E] Add an env var to run on Windows May 21, 2024
@bso-intel bso-intel marked this pull request as ready for review May 22, 2024 18:37
@bso-intel bso-intel requested a review from a team as a code owner May 22, 2024 18:37
@bso-intel
Copy link
Contributor Author

@KseniyaTikhomirova
ping

@bso-intel
Copy link
Contributor Author

@intel/llvm-gatekeepers
ping

@steffenlarsen steffenlarsen merged commit e876532 into intel:sycl May 30, 2024
13 checks passed
@bso-intel bso-intel deleted the device-info branch May 30, 2024 16:10
@AlexeySachkov
Copy link
Contributor

I'm confused by this PR. #12599 from @cperkinsintel says that default context is now enabled by default on Windows and I don't see any mentions of its revert.

Is this env variable needed because we haven't updated user-facing APIs related to default context, so they still don't work by default on Windows?

gDevPool.contexts[0] = std::make_unique<sycl::context>(
gDevPool.devices[0]->get_platform().ext_oneapi_get_default_context());

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants