[SYCL] Use sycl/detail/core.hpp in test-e2e/SubGroupMask/*
#13842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continuation of changes started in intel#12890.
aelovikov-intel
commented
May 20, 2024
| @@ -143,6 +143,19 @@ | |||
| // CHECK-NEXT: detail/spirv.hpp | |||
| // CHECK-NEXT: ext/oneapi/experimental/non_uniform_groups.hpp | |||
| // CHECK-NEXT: ext/oneapi/sub_group_mask.hpp | |||
| // CHECK-NEXT: builtins.hpp | |||
There was a problem hiding this comment.
Normally we would try to avoid growing this, but this change is a bugfix. The proper future change is to move the entire "sub_group_mask" extension out of core.hpp. I expect that to happen in #13760.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
reviewed
May 20, 2024
| @@ -15,8 +15,13 @@ | |||
| // | |||
| //===----------------------------------------------------------------------===// | |||
|
|
|||
| // TODO: switch to <sycl/detail/core.hpp> once we decide how feature macros | |||
There was a problem hiding this comment.
NIT: Do we need this TODO? It looks like test is using core.hpp now.
There was a problem hiding this comment.
You're right. I'll remove that in a follow-up PR because I want this merged to unblock dependent changes.
There was a problem hiding this comment.
Changing it as part of #13853.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of changes started in #12890.