Skip to content

[SYCL][ESIMD][E2E] Reenable some gather and scatter tests #13881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2024
Merged

[SYCL][ESIMD][E2E] Reenable some gather and scatter tests #13881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 8 additions & 17 deletions sycl/test-e2e/ESIMD/unified_memory_api/Inputs/gather.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,10 +452,8 @@ template <typename T, TestFeatures Features> bool testUSM(queue Q) {

// Check VS > 1. GPU supports only dwords and qwords in this mode.
if constexpr (sizeof(T) >= 4) {
// TODO: This test case causes flaky fail. Enable it after the issue
// in GPU driver is fixed.
// Passed &= testUSM<T, 16, 2, UseMask, !UsePassThru, UseProperties>(
// Q, 3, AlignElemProps);
Passed &= testUSM<T, 16, 2, UseMask, !UsePassThru, UseProperties>(
Q, 3, AlignElemProps);

Passed &= testUSM<T, 32, 2, !UseMask, !UsePassThru, UseProperties>(
Q, 3, AlignElemProps);
Expand Down Expand Up @@ -690,10 +688,8 @@ template <typename T, TestFeatures Features> bool testSLM(queue Q) {

// Check VS > 1. GPU supports only dwords and qwords in this mode.
if constexpr (sizeof(T) >= 4) {
// TODO: This test case causes flaky fail. Enable it after the issue
// in GPU driver is fixed.
// Passed &= testUSM<T, 16, 2, UseMask, !UsePassThru, UseProperties>(
// Q, 3, AlignElemProps);
Passed &= testUSM<T, 16, 2, UseMask, !UsePassThru, UseProperties>(
Q, 3, AlignElemProps);

Passed &= testSLM<T, 32, 2, !UseMask, !UsePassThru, UseProperties>(
Q, 3, AlignElemProps);
Expand Down Expand Up @@ -746,10 +742,8 @@ template <typename T, TestFeatures Features> bool testACC(queue Q) {

// Check VS > 1. GPU supports only dwords and qwords in this mode.
if constexpr (sizeof(T) >= 4) {
// TODO: This test case causes flaky fail. Enable it after the issue
// in GPU driver is fixed.
// Passed &= testACC<T, 16, 2, UseMask, !UsePassThru, UseProperties>(
// Q, 3, AlignElemProps);
Passed &= testACC<T, 16, 2, UseMask, !UsePassThru, UseProperties>(
Q, 3, AlignElemProps);

Passed &= testACC<T, 32, 2, !UseMask, !UsePassThru, UseProperties>(
Q, 3, AlignElemProps);
Expand Down Expand Up @@ -996,11 +990,8 @@ template <typename T, TestFeatures Features> bool testLACC(queue Q) {

// Check VS > 1. GPU supports only dwords and qwords in this mode.
if constexpr (sizeof(T) >= 4) {
// TODO: This test case causes flaky fail. Enable it after the issue
// in GPU driver is fixed.
// Passed &= testACC<T, 16, 2, UseMask, !UsePassThru, UseProperties>(
// Q, 3, AlignElemProps);

Passed &= testACC<T, 16, 2, UseMask, !UsePassThru, UseProperties>(
Q, 3, AlignElemProps);
Passed &= testLACC<T, 32, 2, !UseMask, !UsePassThru, UseProperties>(
Q, 3, AlignElemProps);
Passed &= testLACC<T, 32, 2, UseMask, !UsePassThru, UseProperties>(
Expand Down
25 changes: 8 additions & 17 deletions sycl/test-e2e/ESIMD/unified_memory_api/Inputs/scatter.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,10 +518,8 @@ template <typename T, TestFeatures Features> bool testUSM(queue Q) {

// Check VS > 1. GPU supports only dwords and qwords in this mode.
if constexpr (sizeof(T) >= 4) {
// TODO: This test case causes flaky fail. Enable it after the issue
// in GPU driver is fixed.
// Passed &=
// testUSM<T, 16, 2, CheckMask, CheckProperties>(Q, 2, AlignElemProps)
Passed &=
testUSM<T, 16, 2, CheckMask, CheckProperties>(Q, 2, AlignElemProps);
Passed &=
testUSM<T, 32, 2, !CheckMask, CheckProperties>(Q, 2, AlignElemProps);
Passed &=
Expand Down Expand Up @@ -575,10 +573,8 @@ template <typename T, TestFeatures Features> bool testACC(queue Q) {

// Check VS > 1. GPU supports only dwords and qwords in this mode.
if constexpr (sizeof(T) >= 4) {
// TODO: This test case causes flaky fail. Enable it after the issue
// in GPU driver is fixed.
// Passed &=
// testACC<T, 16, 2, CheckMask, CheckProperties>(Q, 2, AlignElemProps)
Passed &=
testACC<T, 16, 2, CheckMask, CheckProperties>(Q, 2, AlignElemProps);
Passed &=
testACC<T, 32, 2, !CheckMask, CheckProperties>(Q, 2, AlignElemProps);
Passed &=
Expand Down Expand Up @@ -630,10 +626,8 @@ template <typename T, TestFeatures Features> bool testSLM(queue Q) {

// Check VS > 1. GPU supports only dwords and qwords in this mode.
if constexpr (sizeof(T) >= 4) {
// TODO: This test case causes flaky fail. Enable it after the issue
// in GPU driver is fixed.
// Passed &=
// testSLM<T, 16, 2, CheckMask, CheckProperties>(Q, 2, AlignElemProps)
Passed &=
testSLM<T, 16, 2, CheckMask, CheckProperties>(Q, 2, AlignElemProps);
Passed &=
testSLM<T, 32, 2, !CheckMask, CheckProperties>(Q, 2, AlignElemProps);
Passed &=
Expand Down Expand Up @@ -853,11 +847,8 @@ template <typename T, TestFeatures Features> bool testLACC(queue Q) {

// Check VS > 1. GPU supports only dwords and qwords in this mode.
if constexpr (sizeof(T) >= 4) {
// TODO: This test case causes flaky fail. Enable it after the issue
// in GPU driver is fixed.
// Passed &=
// testLACC<T, 16, 2, CheckMask, CheckProperties>(Q, 2,
// AlignElemProps)
Passed &=
testLACC<T, 16, 2, CheckMask, CheckProperties>(Q, 2, AlignElemProps);
Passed &=
testLACC<T, 32, 2, !CheckMask, CheckProperties>(Q, 2, AlignElemProps);
Passed &=
Expand Down
Loading