-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][NFC] Doxygen doc for CUDA backend #1394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few typos.
sycl/plugins/cuda/pi_cuda.hpp
Outdated
pi_program program_; | ||
std::atomic_uint32_t refCount_; | ||
|
||
/* | ||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be ///
to align with the rest of project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @alexbatashev are you OK with the patch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please, sign-off your commits
Adding doxygen documentation to PI CUDA backend. Some code is re-ordered in the file to help sorting the doxygen. Co-Authored-By: Alexey Bader <[email protected]> Co-Authored-By: Alexander Batashev <[email protected]> Co-Authored-By: Romanov Vlad <[email protected]> Signed-off-by: Ruyman Reyes <[email protected]>
Adding doxygen documentation to PI CUDA backend.
Some code is re-ordered in the file to help sorting the doxygen.