[SYCL] Simplify handing of builtins in LowerWGScope #1399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naghasan
force-pushed
the
victor/hier_fixes
branch
from
bf084d9 to
f5a102f
Compare
|
I wonder what "fix" mean in the title. Do you have a regression test which exposes the problem? |
Naghasan
changed the title
Naghasan
force-pushed
the
victor/hier_fixes
branch
from
f5a102f to
c6cb179
Compare
Signed-off-by: Victor Lomuller <[email protected]>
Naghasan
force-pushed
the
victor/hier_fixes
branch
from
c6cb179 to
9fdb509
Compare
bader
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a few code simplification/unification for LowerWGScope
Signed-off-by: Victor Lomuller [email protected]