[SYCL][E2E] increase test coverage for subregions copies #14046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cppchedy
commented
Jun 5, 2024
cppchedy
commented
- Updated 2D subregion copy test so that it follows the other subregion tests.
- Updated the 3D and 2D subregion tests to cover test cases for copying with non-zero offsets from device to host.
cppchedy
force-pushed
the
chedy/fix-copy-in-bytes-bug
branch
from
e6854c6 to
6b52b98
Compare
* Updated 2D subregion copy test so that it follows the other subregion tests. * Updated the 3D and 2D subregion tests to cover test cases for copying with non-zero offsets from device to host.
cppchedy
force-pushed
the
chedy/fix-copy-in-bytes-bug
branch
from
6b52b98 to
4f1019f
Compare
przemektmalon
approved these changes
Jun 10, 2024
DBDuncan
approved these changes
Jun 10, 2024
Seanst98
approved these changes
Jun 10, 2024
isaacault
approved these changes
Jun 11, 2024
|
The failed tests in this job aren't related to the bindless images tests updated in this PR. |
callumfare
reviewed
Jun 24, 2024
|
oneapi-src/unified-runtime#1714 has merged, please pull in the latest sycl branch changes and update the UR repo/tag as suggested. |
callumfare
approved these changes
Jun 25, 2024
|
@intel/llvm-gatekeepers Please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.