[SYCL] Disable in-order queue barrier optimization while profiling #14123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… NOP barrier (intel#12949)" This reverts commit 200694b.
Current implementation of profiling info for NOP barriers is inconsistent with other events from the same queue. To make them consistent while keeping the optimization, we would need to duplicate the event on our side and make the duplicate also check and potentially use profiling information of its previous event. Instead, as the first step, disable the NOP optimization during profiling since profiling is known to incur a performance hit anyway. The proper duplicate event approach can be implemented as a follow up if this causes issues for users.
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
approved these changes
Jun 10, 2024
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
approved these changes
Jun 12, 2024
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
ianayl
pushed a commit
to ianayl/sycl
that referenced
this pull request
Jun 13, 2024
…ntel#14123) Current implementation of profiling info for NOP barriers is inconsistent with other events from the same queue (e.g., if the previous event started after the barrier was submitted). To make them consistent while keeping the optimization, we would need to duplicate the event on our side and make the duplicate check and potentially use profiling info of its previous event. Instead, as the first step, disable the NOP optimization during profiling since profiling is known to incur a performance hit anyway. The proper duplicate event approach can be implemented as a follow up if this causes issues for users. Partially reverts intel#12949
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of profiling info for NOP barriers is inconsistent
with other events from the same queue (e.g., if the previous event started
after the barrier was submitted). To make them consistent while keeping
the optimization, we would need to duplicate the event on our side and
make the duplicate check and potentially use profiling info of its
previous event.
Instead, as the first step, disable the NOP optimization during profiling
since profiling is known to incur a performance hit anyway. The proper
duplicate event approach can be implemented as a follow up if this
causes issues for users.
Partially reverts #12949