Skip to content

[SYCL] Integrate the newly-added llvm.tan and llvm.experimental.constrained.tan intrinsics with fp-accuracy. #14193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

tianqingw
Copy link
Contributor

@tianqingw tianqingw commented Jun 17, 2024

This fixes the following LIT tests:

  • clang/test/CodeGen/fp-accuracy.c
  • clang/test/CodeGenSYCL/fp-accuracy.cpp
  • sycl/test/optional_kernel_features/fp-accuracy.c
  • sycl/test/optional_kernel_features/fp-accuracy.cpp.

…onstrained.tan intrinsics.

This fixes the several LIT tests e.g. clang/test/CodeGenSYCL/fp-accuracy.cpp, sycl/test/optional_kernel_features/fp-accuracy.c, sycl/test/optional_kernel_features/fp-accuracy.cpp.
@tianqingw tianqingw changed the title Enable fpbuiltin for the newly added llvm.tan and llvm.experimental.constrained.tan intrinsics. Integrate the newly-added llvm.tan and llvm.experimental.constrained.tan intrinsics with fp-accuracy. Jun 17, 2024
@tianqingw tianqingw marked this pull request as ready for review June 17, 2024 08:41
@tianqingw tianqingw requested a review from a team as a code owner June 17, 2024 08:41
@tianqingw tianqingw changed the title Integrate the newly-added llvm.tan and llvm.experimental.constrained.tan intrinsics with fp-accuracy. [SYCL] Integrate the newly-added llvm.tan and llvm.experimental.constrained.tan intrinsics with fp-accuracy. Jun 17, 2024
@jsji
Copy link
Contributor

jsji commented Jun 26, 2024

@zahiraam Can you have a look? Thanks.

@zahiraam
Copy link
Contributor

@zahiraam Can you have a look? Thanks.

LGTM.

@jsji jsji merged commit 51f0e21 into intel:sycl-web Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants