Skip to content

[SYCL][E2E] Use sycl 2020 exceptions in KernelAndProgram e2e tests #14229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

ayylol
Copy link
Contributor

@ayylol ayylol commented Jun 19, 2024

No description provided.

@ayylol ayylol requested a review from a team as a code owner June 19, 2024 17:31
@ayylol ayylol requested a review from steffenlarsen June 19, 2024 17:31
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do you have plans to change the use of sycl::compile_program_error in the runtime too? Seems like we should replace them by direct uses of sycl::exception as well.

@ayylol ayylol temporarily deployed to WindowsCILock June 21, 2024 16:51 — with GitHub Actions Inactive
@ayylol ayylol temporarily deployed to WindowsCILock June 21, 2024 17:22 — with GitHub Actions Inactive
@againull againull merged commit b6a8e76 into intel:sycl Jun 21, 2024
14 checks passed
@ayylol ayylol deleted the e2e-kernelandprogram branch June 21, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants