[Clang][SYCL][LIT] Fix lb_sm_90.cpp when nvptx target is not enabled #14289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarnie, Nick <[email protected]>
sarnex
changed the title
|
weird that it's running all the tests. It would help to have a better way to handle test updates. |
|
Yeah I just made #14291 for that |
|
@intel/dpcpp-cfe-reviewers Ping on this one? Should be a very easy (one line!) review. Thanks :) |
elizabethandrews
approved these changes
Jun 26, 2024
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fails for me constantly in
check-clanglocally because I don't build nvptx. I verified this is UNSUPPORTED when nvptx is not built and runs and passes when it is built.