[Driver][SYCL][NewOffload] Fix arch settings for nvptx and amd #14340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling for -fsycl-targets values of nvptx64-nvidia-cuda and amdgcn-amd-gpu, the default arch behaviors were not applied to the compilation. Updates to do the following: - Add default of sm_50 for nvptx64 if not provided - Emit diagnostic if no arch provided for amd - Parse -Xsycl-backend-target for offload-arch values
mdtoguchi
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
asudarsa
approved these changes
Jun 28, 2024
hchilama
reviewed
Jun 28, 2024
hchilama
approved these changes
Jun 28, 2024
|
@intel/llvm-gatekeepers, This should be ready for merge - please take a look. |
|
We should really be not running CI testing for comment updates...:-( |
|
@mdtoguchi this is awaiting approval from @srividya-sundaram |
|
We have approval from a driver team reviewer, This change unblocks development by fixing a large number of test failures. So, I ill merge it now. @srividya-sundaram, please feel free to reach out to me or @mdtoguchi for any post-commit changes if required. Thanks |
|
Sorry, I missed the notification for approval request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling for -fsycl-targets values of nvptx64-nvidia-cuda and amdgcn-amd-gpu, the default arch behaviors were not applied to the compilation. Updates to do the following: