[SYCL] Fix command dependency handling when adding a command group #1437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where a dependency vector that was iterated over could have its iterators invalidated inside of the loop. Signed-off-by: Sergey Semenov <[email protected]>
s-kanaev
approved these changes
Mar 31, 2020
vmaksimo
pushed a commit
to vmaksimo/llvm
that referenced
this pull request
Mar 17, 2022
Required after this change done in LLVM upstream:
commit 0c0f6cf
Author: Petr Hosek <[email protected]>
[CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE
This clarifies that this is an LLVM specific variable and avoids
potential conflicts with other projects.
Differential Revision: https://reviews.llvm.org/D119918
Can be observed as:
lit.py: /usr/lib/llvm-15/build/utils/lit/lit/llvm/config.py:304: fatal:
Could not turn '' into Itanium ABI triple
Original commit:
KhronosGroup/SPIRV-LLVM-Translator@697458f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where a dependency vector that was iterated over could
have its iterators invalidated inside of the loop.
Signed-off-by: Sergey Semenov [email protected]