Skip to content

[SYCL] Fix postcommit again #14385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2024
Merged

[SYCL] Fix postcommit again #14385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sycl/source/detail/program_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ void program_impl::link(std::string LinkOptions) {
}

bool program_impl::has_kernel(std::string KernelName,
bool IsCreatedFromSource) const {
bool /*IsCreatedFromSource*/) const {
throw_if_state_is(program_state::none);

std::vector<sycl::detail::pi::PiDevice> Devices(get_pi_devices());
Expand Down
2 changes: 1 addition & 1 deletion sycl/source/detail/sycl_mem_obj_t.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ size_t SYCLMemObjT::getBufSizeForContext(const ContextImplPtr &Context,

bool SYCLMemObjT::isInterop() const { return MOpenCLInterop; }

void SYCLMemObjT::determineHostPtr(const ContextImplPtr &Context,
void SYCLMemObjT::determineHostPtr(const ContextImplPtr & /*Context*/,
bool InitFromUserData, void *&HostPtr,
bool &HostPtrReadOnly) {
// The data for the allocation can be provided via either the user pointer
Expand Down
28 changes: 0 additions & 28 deletions sycl/unittests/scheduler/StreamInitDependencyOnHost.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,31 +47,3 @@ class MockHandlerStreamInit : public MockHandler {
return CommandGroup;
}
};

using CmdTypeTy = sycl::detail::Command::CommandType;

// Function recursively checks that initial command has dependency on chain of
// other commands that should have type DepCmdsTypes[Depth] (Depth is a distance
// - 1 in a command dependencies tree from initial command to a currently
// checked one) and requirement on memory object of stream's flush buffer.
static bool ValidateDepCommandsTree(const detail::Command *Cmd,
const std::vector<CmdTypeTy> &DepCmdsTypes,
const detail::SYCLMemObjI *MemObj,
size_t Depth = 0) {
if (!Cmd || Depth >= DepCmdsTypes.size())
throw sycl::runtime_error("Command parameters are invalid",
PI_ERROR_INVALID_VALUE);

for (const detail::DepDesc &Dep : Cmd->MDeps) {
if (Dep.MDepCommand &&
(Dep.MDepCommand->getType() == DepCmdsTypes[Depth]) &&
Dep.MDepRequirement && (Dep.MDepRequirement->MSYCLMemObj == MemObj) &&
((Depth == DepCmdsTypes.size() - 1) ||
ValidateDepCommandsTree(Dep.MDepCommand, DepCmdsTypes, MemObj,
Depth + 1))) {
return true;
}
}

return false;
}
Loading