Skip to content

[NFC][SYCL] Do not add sycl_device attribute to OpenCL kernel #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2020
Merged

[NFC][SYCL] Do not add sycl_device attribute to OpenCL kernel #1439

merged 1 commit into from
Apr 1, 2020

Conversation

Fznamznon
Copy link
Contributor

It is not needed anymore.

Signed-off-by: Mariya Podchishchaeva [email protected]

@Fznamznon
[NFC][SYCL] Do not add sycl_device attribute to OpenCL kernel
1cd8aaf 
It is not needed anymore.

Signed-off-by: Mariya Podchishchaeva <[email protected]>
@Fznamznon Fznamznon requested a review from bader March 31, 2020 17:14
@AGindinson
Copy link
Contributor

AGindinson commented Mar 31, 2020 •
edited
Loading

It is not needed anymore.

Why? :)

@Fznamznon
Copy link
Contributor Author

It is not needed anymore.

Why? :)

I did some refactoring in previous patches (2225ffd), so adding implicit sycl_device attribute is not required anymore.
We used to add implicit sycl_device attribute to outline device code, now device code outlining is performed by the CodeGen without using of this attribute.

@AGindinson
Copy link
Contributor

I did some refactoring in previous patches (2225ffd), so adding implicit sycl_device attribute is not required anymore.
We used to add implicit sycl_device attribute to outline device code, now device code outlining is performed by the CodeGen without using of this attribute.

Thanks!

@bader bader merged commit 0c3e012 into intel:sycl Apr 1, 2020
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Apr 15, 2020
Merge remote-tracking branch 'origin/sycl' into private/abatashe/basi…
3f9f6d8 
…c_abi_checks

* origin/sycl: (6966 commits)
  [NFC][SYCL] Do not add `sycl_device` attribute to OpenCL kernel (intel#1439)
  [SYCL][NFC] Move SYCL pipe metadata call to be inside the null check for D (intel#1436)
  [SYCL][NFC] Move template function definition to .h file (intel#1433)
  [SYCL] Don't expose vector of booleans as storage format (intel#1419)
  [SYCL] Don't throw exceptions from destructors (intel#1378)
  [BuildBot] Add support for multiple CMake options (intel#1434)
  [SYCL][NFC] Fix warning inline namespace reopened as no-inline (intel#1435)
  [SYCL] Check if loadPlugin returns a nullptr (intel#1411)
  [SYCL] Release notes for February'20 SYCL implementation update (intel#1400)
  [SYCL][Doc] Improve contribution guidelines (intel#1422)
  [BuildBot] Add --cmake-opts option to configure.py script (intel#1430)
  [SYCL] Enable non-read-write memory object mapping in scheduler (intel#1390)
  [SYCL][Driver] Do not store AOT-specific options in the image descriptor (intel#1428)
  [Driver][NFC] Fix string problem used for tracking duplicate triples (intel#1424)
  [SYCL][NFC] Use the non-deprecated setAlignment() in LowerWGScope (intel#1420)
  [SYCL][NFC] Fix formatting in GetStartedGuide (intel#1417)
  [NFC] Move CODEOWNERS file to enable GitHub automation (intel#1418)
  [SYCL] Add test for private array init by zeroes (intel#1402)
  [Driver][SYCL][FPGA] Adjust device and AOCX link order for FPGA (intel#1389)
  [SYCL] Change runtime check to assert in program_manager.cpp (intel#1413)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fznamznon @AGindinson @bader