[DeviceSanitizer] Change "TargetTriple.isSPIR()" to "TargetTriple.isSPIROrSPIRV()" in AddressSanitizer.cpp

[AllanZyne]

SYCL is going to switch to SPIR-V backend soon, this PR changed "TargetTriple.isSPIR()" to "TargetTriple.isSPIROrSPIRV()" to improve compatibility

[sarnex]

TY!

[zhaomaosu]

lgtm

[asudarsa]

It seems like this change might have exposed a latent bug in the SPIR-V backend code. @michalpaszkowski, can you please comment how to address the windows failure reported in the CI?

Thanks

[asudarsa]

@AllanZyne

Can you please add a line or two in the PR description about the need for this change? Just for logging purposes.

Thanks

[AllanZyne]

@AllanZyne

Can you please add a line or two in the PR description about the need for this change? Just for logging purposes.

Thanks

Done.

[AllanZyne]

Hi @intel/llvm-gatekeepers, the failed test is not related to this test, this patch needs test using"-fsanitize=address" flag.
Thanks!

[michalpaszkowski]

It seems like this change might have exposed a latent bug in the SPIR-V backend code. @michalpaszkowski, can you please comment how to address the windows failure reported in the CI?

Thanks

I wasn't able to reproduce the failure on a Windows build of SPIR-V backend both from this branch or the llvm-project repository. It might be the case that there is some memory leak/ownership issues inside LLVM (either in SPIR-V backend or otherplace), but this will require a bit more investigation. Unfortunately, rerunning this test many times does not help much.

@asudarsa @AllanZyne Would it be possible to rerun the Windows CI run? (I don't have such access in this repository to do this myself)

[sommerlukas]

Can you try merging the latest changes from the sycl branch into your branch? There was some improvements made to Windows CI yesterday.

[AllanZyne]

Can you try merging the latest changes from the sycl branch into your branch? There was some improvements made to Windows CI yesterday.

Sure

[AllanZyne]

Hi @intel/llvm-gatekeepers, please merge.
Thanks!