Skip to content

[SYCL][NVPTX] Do not decompose SYCL functor unless necessary #14434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 18, 2024

Conversation

Naghasan
Copy link
Contributor

@Naghasan Naghasan commented Jul 3, 2024

CUDA backend can support passing pointer in the generic address space. The patch prevent the decomposition of the SYCL functor if there is no special types in it.

CUDA backend can support passing pointer in the generic address space.
The patch prevent the decomposition of the SYCL functor if there is no special types in it.

Signed-off-by: Victor Lomuller <[email protected]>
@Naghasan
Copy link
Contributor Author

Naghasan commented Jul 3, 2024

@elizabethandrews @tahonermann That's the patch I mentioned the other day, still early and missing tests obviously. But if you can spare a bit of time to give a high level feedback, that would be great. Thanks.

Note: the patch is aimed to be used with #14332

@Naghasan
Copy link
Contributor Author

Naghasan commented Jul 3, 2024

Note 2: I'm aware of the test failures (and why) and I'm also restricting to nvptx at the moment to avoid fixing a large number of tests.

@Naghasan Naghasan temporarily deployed to WindowsCILock July 4, 2024 01:01 — with GitHub Actions Inactive
@Naghasan Naghasan marked this pull request as ready for review July 8, 2024 21:43
@Naghasan Naghasan requested review from a team as code owners July 8, 2024 21:43
@Naghasan Naghasan requested a review from uditagarwal97 July 8, 2024 21:43
@Naghasan Naghasan temporarily deployed to WindowsCILock July 9, 2024 00:49 — with GitHub Actions Inactive
@Naghasan Naghasan requested a review from a team as a code owner July 9, 2024 08:21
@Naghasan Naghasan temporarily deployed to WindowsCILock July 9, 2024 08:22 — with GitHub Actions Inactive
@Naghasan Naghasan temporarily deployed to WindowsCILock July 9, 2024 08:55 — with GitHub Actions Inactive
Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for driver

Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SYCL Changes LGTM.

Copy link
Contributor

@victor-eds victor-eds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kernel fusion test change LGTM

Copy link
Contributor

@elizabethandrews elizabethandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to note here is that pointers in decomposed structs i.e. those in a struct with special types will have different address space handing than those which are in structs not decomposed. Is that discrepancy ok?

@Naghasan
Copy link
Contributor Author

One thing to note here is that pointers in decomposed structs i.e. those in a struct with special types will have different address space handing than those which are in structs not decomposed. Is that discrepancy ok?

Yes, and it can even be important to have it. When not decomposed, pointers are basically treated as CUDA would but that only applies to global pointers. Where it is important to decompose and keep the address space is for the local one as for CUDA we need to pass an offset instead.

@Naghasan
Copy link
Contributor Author

@intel/llvm-gatekeepers The PR is ready to merge, the windows failure is unrelated.

Fails during AOT compilation for the following reason:

Could not determine device target: cfl.
Cannot get HW Info for device cfl.

@Naghasan
Copy link
Contributor Author

FYI @intel/dpcpp-devops-reviewers

@martygrant martygrant merged commit 7a9d3b1 into intel:sycl Jul 18, 2024
13 of 14 checks passed
@Naghasan Naghasan deleted the victor/kernel-blob branch July 18, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants