-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][ABI-Break] Remove getRawSyclObjImpl() from headers #14585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fails seem to have been addressed by #14589! It seems that a test case in |
Friendly ping @uditagarwal97, this should be ready for review. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SYCL Changes LGTM!
@intel/bindless-images-reviewers @intel/sycl-graphs-reviewers Friendly ping, this is ready for review. Thanks in advance! |
@intel/sycl-graphs-reviewers , today is the deadline for the ABI breaking changes, please review ASAP! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Graph changes LGTM
Thanks Fabio and Andrei! @intel/llvm-gatekeepers This should be ready for merging. The Windows E2E test errors seem to be an issue with the runner, but correct me if I'm wrong. |
Yep, fixed in HEAD already. |
As per #10474, I have:
getRawSyclObjImpl
getSyclObjImpl
to return a reference instead