[SYCL] Remove unnamed lambda check from headers #14614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the SYCL headers checks for unnamed lambdas in the case where they have been disabled. However, this falsely flags functor objects which should not be covered by the unnamed lambda restriction. Luckily, the compiler already issues diagnostics for illegal unnamed lambdas, so this patch removes the check from the headers and instead relies on the frontend for issuing diagnostics for the illegal cases. Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the SYCL headers checks for unnamed lambdas in the case where they have been disabled. However, this falsely flags functor objects which should not be covered by the unnamed lambda restriction. Luckily, the compiler already issues diagnostics for illegal unnamed lambdas, so this patch removes the check from the headers and instead relies on the frontend for issuing diagnostics for the illegal cases.