-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][ABI-Break] Hide getPlugin symbol #14616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AlexeySachkov
merged 1 commit into
intel:sycl
from
AlexeySachkov:private/asachkov/drop-get-plugin-symbol
Jul 18, 2024
Merged
[SYCL][ABI-Break] Hide getPlugin symbol #14616
AlexeySachkov
merged 1 commit into
intel:sycl
from
AlexeySachkov:private/asachkov/drop-get-plugin-symbol
Jul 18, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is not called anywhere from SYCL headers and therefore there is no reason to have it exported. It was made exported as part of ESIMD emulator plugin addition (intel#2963), but that plugin was since then deprecated and removed (intel#13295).
steffenlarsen
approved these changes
Jul 18, 2024
We should drop Lines 71 to 92 in 7d7ab2f
|
aelovikov-intel
approved these changes
Jul 18, 2024
AlexeySachkov
added a commit
to AlexeySachkov/llvm
that referenced
this pull request
Jul 18, 2024
This is a follow-up for intel#14616 to drop special-casing some of SYCL RT functions that we don't export anymore.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is not called anywhere from SYCL headers and therefore there is no reason to have it exported.
It was made exported as part of ESIMD emulator plugin addition (#2963), but that plugin was since
then deprecated and removed (#13295).
This is patch is essentially a by-product of #14145 and it is done to simplify that change, i.e. PI plugins removal should not be ABI-breaking by itself, we just need to cleanup some of our exported symbols.