[SYCL] Add compile target to device image properties #14757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ; RUN: FileCheck %s -input-file=%t_intel_gpu_pvc_3.prop -check-prefix=CHECK-PVC-PROP | ||
| ; RUN: FileCheck %s -input-file=%t_intel_gpu_pvc_4.prop -check-prefix=CHECK-PVC-PROP | ||
| ; RUN: FileCheck %s -input-file=%t_intel_gpu_pvc_5.prop -check-prefix=CHECK-PVC-PROP | ||
| ; CHECK-PVC-PROP: compile_target=2|oBAAAAAAAAQauRXZs91ZwV3XwZ3Y |
There was a problem hiding this comment.
Note for reviewers about encoding this information into device image properties instead of re-using a dedicated field within device image data structure: as part of our transition to clang-linker-wrapper will try and unify our device image descriptors with those used in the upstream. There is an equivalent to our properties in there, but there are no dedicated field for device image target. Therefore, here we are using a mechanism that will be easier to transition later.
AlexeySachkov
approved these changes
Jul 26, 2024
AlexeySachkov
pushed a commit
that referenced
this pull request
Aug 15, 2024
…rty (#14909) We allow multiple so-called "special" targets to be passed to `-fsycl-targets`, but without extra information SYCL RT wouldn't be able to select the right AOT-compiled device image. #14757 introduced a device image property to specify an exact target for a device image and this patch made runtime honor that property when selecting a device image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when compiling with any
intel_gpu_*target, the device image only had the genericspir64_genas its value for theDeviceTargetSpecin its device image, so there was no way to differentiate device images compiled for a specific GPU in the runtime. Now, a new property is added to the image specifying the specificintel_gpu_*value it is compiled for.