Skip to content

[SYCL] Fix use of removed ArchType enum #14833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

frasercrmck
Copy link
Contributor

Two concurrent PRs added a new use of and simultaneously removed this enum. Commit 63c61d8 added a new use, while dc37699 was trying to delete it.

Two concurrent PRs added a new use of and simultaneously removed this
enum. Commit 63c61d8 added a new use, while dc37699 was trying to
delete it.
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really review deeply this for correctness but it seems sane. I'll merge once build CI passes to try unbreaking it for everyone.

@sarnex
Copy link
Contributor

sarnex commented Jul 29, 2024

Build CI passed

@sarnex sarnex merged commit e664798 into intel:sycl Jul 29, 2024
8 of 9 checks passed
@frasercrmck frasercrmck deleted the sycl-fix-archtype-conflict branch July 29, 2024 19:08
@bader
Copy link
Contributor

bader commented Jul 29, 2024

I can't really review deeply this for correctness but it seems sane. I'll merge once build CI passes to try unbreaking it for everyone.

@intel/dpcpp-devops-reviewers, GitHub merge queue is the solution for this type of issues. Please, consider enabling this feature for the project.

@sarnex
Copy link
Contributor

sarnex commented Jul 29, 2024

GitHub merge queue is the solution for this type of issues. Please, consider enabling this feature for the project.

@stdale-intel Can you consider the above? Thanks

AlexeySachkov pushed a commit to AlexeySachkov/llvm that referenced this pull request Nov 26, 2024
Two concurrent PRs added a new use of and simultaneously removed this
enum. Commit 63c61d8 added a new use, while dc37699 was trying to
delete it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants