[SYCL][Doc] Add draft of sycl_ext_oneapi_joint_for #14886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a proposed extension for encapsulating the pattern of distributing loops across the work-items in a group. Signed-off-by: John Pennycook <[email protected]>
Pennycook
added
the
spec extension
|
@intel/dpcpp-specification-reviewers - I think this one might have slipped through the cracks. Friendly ping. |
gmlueck
reviewed
Aug 30, 2024
sycl/doc/extensions/proposed/sycl_ext_oneapi_joint_for.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_joint_for.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_joint_for.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_joint_for.asciidoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Greg Lueck <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Matches ExecutionPolicy overload of std::for_each. Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
gmlueck
approved these changes
Sep 3, 2024
|
@intel/llvm-gatekeepers, this can be merged now. |
| namespace sycl::ext::oneapi::experimental { | ||
|
|
||
| template <typename Group, typename InputIterator, typename Function> | ||
| void joint_for_each(Group g, InputIterator first, InputIterator last, Function f); |
There was a problem hiding this comment.
Why that and not something like
for (auto &&elem : group_view_name(g, first, last)) /* ... */
?
There was a problem hiding this comment.
The rest of the functions in the group algorithms library are based on std:: algorithms, (e.g., std::reduce becomes sycl::joint_reduce, std::exclusive_scan becomes sycl::joint_exclusive_scan) and so following that precedent here seems the most natural: std::for_each becomes sycl::joint_for_each.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a proposed extension for encapsulating the pattern of distributing loops across the work-items in a group.